Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Yuncheng Lu as maintainer #1628

Merged
merged 1 commit into from
May 3, 2024

Conversation

VijayanB
Copy link
Member

Description

Add Yuncheng Lu as maintainer to k-NN repository

Issues Resolved

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed as per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Add Yuncheng Lu as maintainer to k-NN repository

Signed-off-by: Vijayan Balasubramanian <[email protected]>
@VijayanB VijayanB force-pushed the update-maintainer branch from 75feac3 to 6de7ba7 Compare April 18, 2024 20:04
@VijayanB VijayanB changed the title Update MAINTAINERS.md Add Yuncheng Lu as maintainer Apr 18, 2024
@VijayanB
Copy link
Member Author

Tagging for review @opensearch-project/plugins

@VijayanB
Copy link
Member Author

Will merge once i get approval from ticket

@VijayanB VijayanB self-assigned this Apr 30, 2024
@VijayanB
Copy link
Member Author

VijayanB commented May 1, 2024

@luyuncheng Did you receive invitation to be outside collaborator?

@luyuncheng
Copy link
Collaborator

@luyuncheng Did you receive invitation to be outside collaborator?

@VijayanB yes, I have been accepted the invitation.

@VijayanB VijayanB merged commit ef962ec into opensearch-project:main May 3, 2024
50 of 52 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-1628-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 ef962ecace122af12cad6b0554a9b09c2d8a58dd
# Push it to GitHub
git push --set-upstream origin backport/backport-1628-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-1628-to-2.x.

VijayanB added a commit to VijayanB/k-NN-2 that referenced this pull request May 16, 2024
Add Yuncheng Lu as maintainer to k-NN repository

Signed-off-by: Vijayan Balasubramanian <[email protected]>
(cherry picked from commit ef962ec)
VijayanB added a commit that referenced this pull request May 16, 2024
Add Yuncheng Lu as maintainer to k-NN repository

Signed-off-by: Vijayan Balasubramanian <[email protected]>
(cherry picked from commit ef962ec)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants