Separate common lib jni and non-jni into 2 libs #1620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Creates a new shared non-jni library that the jni libraries can depend on. This is to resolve a build issue on windows that is coming from nmslib not being able to find symbols in the jni common library. The net result will be that we add one more shared library. In addition, I removed all the CPack code from CMakeLists because we dont use it. Signed-off-by: John Mazanec <[email protected]>
jmazanec15
requested review from
heemin32,
navneet1v,
VijayanB,
vamshin,
naveentatikonda,
junqiu-lei,
martin-gaievski and
ryanbogan
as code owners
jmazanec15
added
Infrastructure
navneet1v
reviewed
Apr 17, 2024
|
Overall code looks good to me. Waiting for all CIs to complete. |
|
@navneet1v failure seems unrelated (#1622 ). See it happening in a couple of other PRs: |
martin-gaievski
approved these changes
Apr 17, 2024
junqiu-lei
approved these changes
Apr 17, 2024
ryanbogan
approved these changes
Apr 17, 2024
navneet1v
approved these changes
Apr 18, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Apr 18, 2024
Creates a new shared non-jni library that the jni libraries can depend on. This is to resolve a build issue on windows that is coming from nmslib not being able to find symbols in the jni common library. The net result will be that we add one more shared library. In addition, I removed all the CPack code from CMakeLists because we dont use it. Signed-off-by: John Mazanec <[email protected]> (cherry picked from commit dc0953a)
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Creates a new shared non-jni library that the jni libraries can depend on. This is to resolve a build issue on windows that is coming from nmslib not being able to find symbols in the jni common library. The net result will be that we add one more shared library.
In addition, I removed all the CPack code from CMakeLists because we dont use it.
Issues Resolved
#1610
#1591
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.