Add arm64 check when SIMD is disabled #1618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ryan Bogan <[email protected]>
ryanbogan
requested review from
heemin32,
navneet1v,
VijayanB,
vamshin,
jmazanec15,
naveentatikonda,
junqiu-lei and
martin-gaievski
as code owners
Signed-off-by: Ryan Bogan <[email protected]>
jmazanec15
reviewed
Apr 17, 2024
CHANGELOG.md
Outdated
| @@ -20,6 +20,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), | |||
| * Implemented the Streaming Feature to stream vectors from Java to JNI layer to enable creation of larger segments for vector indices [#1604](https://github.com/opensearch-project/k-NN/pull/1604) | |||
| * Remove unnecessary toString conversion of vector field and added some minor optimization in KNNCodec [1613](https://github.com/opensearch-project/k-NN/pull/1613) | |||
| ### Bug Fixes | |||
| * Add arm64 check when SIMD is disabled [#1618](https://github.com/opensearch-project/k-NN/pull/1618) | |||
There was a problem hiding this comment.
I would say this is infrastructure as it doesnt impact prod code
jmazanec15
previously approved these changes
Apr 18, 2024
Signed-off-by: Ryan Bogan <[email protected]>
martin-gaievski
approved these changes
Apr 18, 2024
|
Windows failure not related to this change. |
jmazanec15
approved these changes
Apr 18, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Apr 18, 2024
* Add arm64 check when SIMD is disabled Signed-off-by: Ryan Bogan <[email protected]> * Add Changelog entry Signed-off-by: Ryan Bogan <[email protected]> * Change entry in changelog to infrastructure Signed-off-by: Ryan Bogan <[email protected]> --------- Signed-off-by: Ryan Bogan <[email protected]> (cherry picked from commit a2bb6cc)
martin-gaievski
pushed a commit
that referenced
this pull request
Apr 18, 2024
* Add arm64 check when SIMD is disabled Signed-off-by: Ryan Bogan <[email protected]> * Add Changelog entry Signed-off-by: Ryan Bogan <[email protected]> * Change entry in changelog to infrastructure Signed-off-by: Ryan Bogan <[email protected]> --------- Signed-off-by: Ryan Bogan <[email protected]> (cherry picked from commit a2bb6cc) Co-authored-by: Ryan Bogan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There is currently a bug when attempting to run k-NN plugin with arm64 and simd disabled, where the
cmakecommand fails and integration tests cannot be run. This PR adds a check similar to the existing aarch64 check that allows the command to complete successfully.Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.