Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bwc workflow to include 2.12.0-SNAPSHOT #1300

Merged
merged 2 commits into from
Nov 9, 2023

Conversation

ryanbogan
Copy link
Member

@ryanbogan ryanbogan commented Nov 7, 2023

Description

Updates the bwc workflow to pull from 2.12.0-SNAPSHOT. This fixes the failing rolling upgrade bwc tests on CI.

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed as per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

codecov bot commented Nov 7, 2023

Codecov Report

Merging #1300 (1bd6762) into main (c72f096) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #1300   +/-   ##
=========================================
  Coverage     85.07%   85.07%           
  Complexity     1210     1210           
=========================================
  Files           160      160           
  Lines          4931     4931           
  Branches        449      449           
=========================================
  Hits           4195     4195           
  Misses          540      540           
  Partials        196      196           

@VijayanB
Copy link
Member

VijayanB commented Nov 9, 2023

@ryanbogan Did you make this change manually? i think we have command to automate this process? i may be wrong too @naveentatikonda do you aware of this?

@ryanbogan
Copy link
Member Author

@ryanbogan Did you make this change manually? i think we have command to automate this process? i may be wrong too @naveentatikonda do you aware of this?

Yeah, I raised the PR manually. The only automated PR's I've seen are for 2.x, not for main.

@VijayanB
Copy link
Member

VijayanB commented Nov 9, 2023

@ryanbogan Did you make this change manually? i think we have command to automate this process? i may be wrong too @naveentatikonda do you aware of this?

Yeah, I raised the PR manually. The only automated PR's I've seen are for 2.x, not for main.

Got it. Can you create an issue to automate on main too?

@ryanbogan ryanbogan merged commit 87ddcb6 into opensearch-project:main Nov 9, 2023
56 of 59 checks passed
@ryanbogan ryanbogan deleted the update_bwc branch November 9, 2023 19:44
@naveentatikonda
Copy link
Member

@VijayanB @ryanbogan We have the logic to update the bwc version in main branch as well. But, as of now it gets triggered when the OS version bump PR is created. Need to figure out a way to update bwc version on main when it is updated on 2.x branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants