-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update developer guide to include M1 Setup #1222
Merged
martin-gaievski
merged 7 commits into
opensearch-project:main
from
ryanbogan:update_developer_guide
Oct 20, 2023
Merged
Update developer guide to include M1 Setup #1222
martin-gaievski
merged 7 commits into
opensearch-project:main
from
ryanbogan:update_developer_guide
Oct 20, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ryan Bogan <[email protected]>
Signed-off-by: Ryan Bogan <[email protected]>
ryanbogan
requested review from
heemin32,
navneet1v,
VijayanB,
vamshin,
jmazanec15,
naveentatikonda,
junqiu-lei and
martin-gaievski
as code owners
October 9, 2023 18:10
Signed-off-by: Ryan Bogan <[email protected]>
Signed-off-by: Ryan Bogan <[email protected]>
navneet1v
reviewed
Oct 10, 2023
navneet1v
previously approved these changes
Oct 11, 2023
heemin32
previously approved these changes
Oct 11, 2023
Signed-off-by: Ryan Bogan <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #1222 +/- ##
============================================
- Coverage 85.07% 85.07% -0.01%
Complexity 1210 1210
============================================
Files 160 160
Lines 4932 4930 -2
Branches 449 449
============================================
- Hits 4196 4194 -2
Misses 537 537
Partials 199 199 |
navneet1v
previously approved these changes
Oct 12, 2023
heemin32
previously approved these changes
Oct 12, 2023
heemin32
reviewed
Oct 12, 2023
Co-authored-by: Heemin Kim <[email protected]> Signed-off-by: Ryan Bogan <[email protected]>
martin-gaievski
approved these changes
Oct 19, 2023
naveentatikonda
approved these changes
Oct 20, 2023
martin-gaievski
merged commit Oct 20, 2023
318cf48
into
opensearch-project:main
36 of 42 checks passed
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-1222-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 318cf481d8d240b533f7fc2ccb4901b01913146e
# Push it to GitHub
git push --set-upstream origin backport/backport-1222-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x Then, create a pull request where the |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates developer guide to include setup on Mac M1 machines
Issues Resolved
#580
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.