Add FAIS delete model API #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VijayanB
added
the
Features
jmazanec15
reviewed
Oct 5, 2021
src/main/java/org/opensearch/knn/plugin/rest/RestDeleteModelHandler.java
Outdated
Show resolved
Hide resolved
Added delete model API to delete previously added model for given ModelID. This requires Handler to register route and prepare request, DeleteModelRequest, DeleteModelResponse to represent request and response, DeleteModelTransportAction to sends request across nodes. Signed-off-by: Vijayan Balasubramanian <[email protected]>
jmazanec15
pushed a commit
to jmazanec15/k-NN-1
that referenced
this pull request
Oct 22, 2021
Added delete model API to delete previously added model for given ModelID. This requires Handler to register route and prepare request, DeleteModelRequest, DeleteModelResponse to represent request and response, DeleteModelTransportAction to sends request across nodes. Signed-off-by: Vijayan Balasubramanian <[email protected]>
jmazanec15
pushed a commit
that referenced
this pull request
Oct 22, 2021
Added delete model API to delete previously added model for given ModelID. This requires Handler to register route and prepare request, DeleteModelRequest, DeleteModelResponse to represent request and response, DeleteModelTransportAction to sends request across nodes. Signed-off-by: Vijayan Balasubramanian <[email protected]>
martin-gaievski
pushed a commit
to martin-gaievski/k-NN
that referenced
this pull request
Mar 7, 2022
Added delete model API to delete previously added model for given ModelID. This requires Handler to register route and prepare request, DeleteModelRequest, DeleteModelResponse to represent request and response, DeleteModelTransportAction to sends request across nodes. Signed-off-by: Vijayan Balasubramanian <[email protected]>
martin-gaievski
pushed a commit
to martin-gaievski/k-NN
that referenced
this pull request
Mar 7, 2022
Added delete model API to delete previously added model for given ModelID. This requires Handler to register route and prepare request, DeleteModelRequest, DeleteModelResponse to represent request and response, DeleteModelTransportAction to sends request across nodes. Signed-off-by: Vijayan Balasubramanian <[email protected]> Signed-off-by: Martin Gaievski <[email protected]>
martin-gaievski
pushed a commit
to martin-gaievski/k-NN
that referenced
this pull request
Mar 30, 2022
Added delete model API to delete previously added model for given ModelID. This requires Handler to register route and prepare request, DeleteModelRequest, DeleteModelResponse to represent request and response, DeleteModelTransportAction to sends request across nodes. Signed-off-by: Vijayan Balasubramanian <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Vijayan Balasubramanian [email protected]
Description
Added delete model API to delete previously added model for given ModelID.
This requires Handler to register route and prepare request,
DeleteModelRequest, DeleteModelResponse to represent request and response,
DeleteModelTransportAction to sends request across nodes.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.