Move model metadata retrieval out of mapper build method #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VijayanB
reviewed
Oct 4, 2021
|
|
||
| public KNNVectorFieldType(String name, Map<String, String> meta, int dimension) { | ||
| super(name, false, false, true, TextSearchInfo.NONE, meta); | ||
| this.dimension = dimension; | ||
| this.modelId = null; // By default, this is null. It will only be set for a mapping with a modelId set. |
There was a problem hiding this comment.
This constructor should call other constructor with modelId as null
There was a problem hiding this comment.
Good point, will update
jmazanec15
force-pushed
the
model-metadata-fix
branch
from
29d9b27 to
f76099f
Compare
Signed-off-by: John Mazanec <[email protected]>
Signed-off-by: John Mazanec <[email protected]>
jmazanec15
force-pushed
the
model-metadata-fix
branch
from
f76099f to
87b7b58
Compare
Signed-off-by: John Mazanec <[email protected]>
jmazanec15
force-pushed
the
model-metadata-fix
branch
from
87b7b58 to
9ed7e52
Compare
VijayanB
reviewed
Oct 5, 2021
| ModelMetadata modelMetadata = this.modelDao.getMetadata(modelId); | ||
|
|
||
| if (modelMetadata == null) { | ||
| throw new IllegalStateException("Model \"" + modelId + "\" does not exist. A new index will need to " + |
VijayanB
approved these changes
Oct 5, 2021
Signed-off-by: John Mazanec <[email protected]>
jmazanec15
added a commit
to jmazanec15/k-NN-1
that referenced
this pull request
Oct 22, 2021
…project#111) Signed-off-by: Jack Mazanec <[email protected]>
jmazanec15
added a commit
that referenced
this pull request
Oct 22, 2021
Signed-off-by: Jack Mazanec <[email protected]>
martin-gaievski
pushed a commit
to martin-gaievski/k-NN
that referenced
this pull request
Mar 7, 2022
…project#111) Signed-off-by: Jack Mazanec <[email protected]>
martin-gaievski
pushed a commit
to martin-gaievski/k-NN
that referenced
this pull request
Mar 7, 2022
…project#111) Signed-off-by: Jack Mazanec <[email protected]> Signed-off-by: Martin Gaievski <[email protected]>
martin-gaievski
pushed a commit
to martin-gaievski/k-NN
that referenced
this pull request
Mar 30, 2022
…project#111) Signed-off-by: Jack Mazanec <[email protected]>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change moves model metadata retrieval out of the model mapper build logic. The reason for this can be found in #110. From a user's perspective, the model_id they pass in during index creation will not be validated until they start ingesting documents.
As a side effect of this change, we can no longer write values such as KNNEngine and SpaceType to the Mapper's Lucene fieldType. These values are read elsewhere in the plugin, such as during indexing in the KNNDocValuesConsumer, as well as during querying. Therefore, that logic needed to be changed as well.
I tested the changes manually on my train API implementation and they work. I also added a single node test case that creates an index from a model. Currently, this fails due to an issue with writing the timestamp. I will submit another PR to fix this.
Issues Resolved
#110
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.