Fixing the Engine specific files from INDEX_STORE_HYBRID_NIO_EXTENSIONS list to make sure engine files are getting mmapped #1054
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR includes:
INDEX_STORE_HYBRID_NIO_EXTENSIONS
list to make sure engine files are getting mmapped.For 1, Core team introduced a change which resulted in deprecating the setting:
INDEX_STORE_HYBRID_MMAP_EXTENSIONS
, hence as the setting was deprecated the unit tests were failing with error, as warnings were getting generated.With this change we are removing the
.vec
and.vex
file(Engine specific files) fromINDEX_STORE_HYBRID_NIO_EXTENSIONS
to make sure that.vec
and.vex
files are getting mmaped. As per the documentation , if file extensions are not present inINDEX_STORE_HYBRID_NIO_EXTENSIONS
they will be Mmapped.Files list on node after the change
Files list on node before the change
Issues Resolved
#995
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.