Fixes possible negative jitter #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Drew Baugher <[email protected]>
thalurur
reviewed
Nov 1, 2021
thalurur
approved these changes
Nov 1, 2021
qreshi
added a commit
that referenced
this pull request
Nov 4, 2021
* Enabled automated license header checks (#36) 1. Re-enabled the 'licenseHeaders' check in the build.gradle file. 2. Added an IntelliJ copyright profile to auto-generate the SPDX license header. Signed-off-by: Ketan Verma <[email protected]> * Release 1.0.0.0 (#40) Signed-off-by: bowenlan-amzn <[email protected]> * Bumping job-scheduler to build with OpenSearch(main) 1.1.0 (#44) * Bumping job-scheduler to build with OpenSearch(main) 1.1.0 Signed-off-by: Sarat Vemulapalli <[email protected]> * Updating docs link to our documentation website. Signed-off-by: Sarat Vemulapalli <[email protected]> * Using 1.1 snapshot version for OpenSearch (#48) Signed-off-by: Vacha <[email protected]> * Use standard snapshot build settings and OpenSearch 1.x. (#49) Signed-off-by: dblock <[email protected]> * Add `Getting Started` to Readme (#50) * added Getting Started section * Adds a delay parameter to the job scheduler (#61) * Adds delay parameter to job scheduler * Adds tests for job scheduler delay parameter * Changes test and build workflow to 1.1 and corrects links Signed-off-by: Clay Downs <[email protected]> * Updates job scheduler version to 1.2 (#68) * Updates job scheduler version to 1.2 and uses Maven for 1.2 dependencies Signed-off-by: Clay Downs <[email protected]> * Publish MD5 and SHA1 signatures. (#71) * Publish MD5 and SHA1 signatures. Signed-off-by: dblock <[email protected]> * Also publish 256 and 512 checksums. Signed-off-by: dblock <[email protected]> * Fixes possible negative jitter (#78) Signed-off-by: Drew Baugher <[email protected]> Co-authored-by: Ketan Verma <[email protected]> Co-authored-by: Bowen Lan <[email protected]> Co-authored-by: Sarat Vemulapalli <[email protected]> Co-authored-by: Vacha <[email protected]> Co-authored-by: Daniel Doubrovkine (dB.) <[email protected]> Co-authored-by: Sriram <[email protected]> Co-authored-by: Clay Downs <[email protected]> Co-authored-by: Drew Baugher <[email protected]>
wuychn
pushed a commit
to ochprince/job-scheduler
that referenced
this pull request
Mar 16, 2023
Signed-off-by: Drew Baugher <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Drew Baugher [email protected]
Description
Current logic of jitter allows a negative value to be set and throw an exception
ISM job fails to run after that, this appears to have be introduced with the recent change of adding support for using jitter in ISM (opensearch-project/index-management@ab12279), as previously ISM was not using it in OpenSearch and would not have hit this issue.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.