Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change XContentType to MediaType #436

Merged
merged 1 commit into from
Jul 31, 2023
Merged

Change XContentType to MediaType #436

merged 1 commit into from
Jul 31, 2023

Conversation

heemin32
Copy link
Contributor

@heemin32 heemin32 commented Jul 27, 2023 •
edited
Loading

Description

Change XContentType to MediaType

Issues Resolved

#433

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

joshpalis
joshpalis previously approved these changes Jul 28, 2023
View reviewed changes
@joshpalis
Copy link
Member

@heemin32 BWC tests are failing since the sample extension plugin is still using OpenSearch version 2.9.0, whilst 2.x has been bumped up to 2.10.0. The sample extension plugin is used to run Job Scheduler BWC tests. In order to resolve this failure, it is necessary to update the version number here to 2.10.0

@heemin32 heemin32 changed the title Change XContentType to MediaType Change XContentType to MediaType + bwc version bump Jul 28, 2023
@heemin32 heemin32 changed the title Change XContentType to MediaType + bwc version bump Change XContentType to MediaType Jul 28, 2023
@heemin32 heemin32 requested a review from joshpalis July 28, 2023 23:54
@heemin32
Copy link
Contributor Author

@heemin32 BWC tests are failing since the sample extension plugin is still using OpenSearch version 2.9.0, whilst 2.x has been bumped up to 2.10.0. The sample extension plugin is used to run Job Scheduler BWC tests. In order to resolve this failure, it is necessary to update the version number here to 2.10.0

Bumping the version to 2.10.0 fails because 2.10.0 is not available in maven repo. Will ignore bwc test for now.

@kaituo kaituo merged commit ab005ba into opensearch-project:main Jul 31, 2023
@heemin32 heemin32 deleted the patch branch July 31, 2023 18:42
@heemin32
Copy link
Contributor Author

heemin32 commented Aug 1, 2023

@heemin32 BWC tests are failing since the sample extension plugin is still using OpenSearch version 2.9.0, whilst 2.x has been bumped up to 2.10.0. The sample extension plugin is used to run Job Scheduler BWC tests. In order to resolve this failure, it is necessary to update the version number here to 2.10.0

I think the reason why BWC tests are failing is because 2.9.0 release does not contain job-scheduler plugin in it.

@joshpalis
Copy link
Member

Main is only wire compatible with the latest 2.x, which is currently 2.10.0, BWC tests will continue to fail until BWC tests are bumped up to 2.10.0 on the main branch, which i see there is a PR to do so here

CC : @cwperks

@joshpalis joshpalis mentioned this pull request Aug 1, 2023
Merged
5 tasks
@joshpalis
Copy link
Member

BWC tests for main has been fixed, raising manual backport of this PR here, to resolve build failures of the 2.x branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbwiddis dbwiddis dbwiddis approved these changes

@kaituo kaituo kaituo approved these changes

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@vibrantvarun vibrantvarun Awaiting requested review from vibrantvarun vibrantvarun is a code owner

@joshpalis joshpalis Awaiting requested review from joshpalis joshpalis is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@heemin32 @joshpalis @kaituo @dbwiddis