Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrades Index Management to use 2.0.0-alpha1 of OpenSearch and depen… #318

Merged
merged 1 commit into from
Apr 1, 2022

Conversation

dbbaughe
Copy link
Contributor

@dbbaughe dbbaughe commented Mar 31, 2022

…dencies

Signed-off-by: Drew Baugher [email protected]

Description of changes:

  • Drops support for JDK 8 and 14
  • Adds support for JDK 17
  • Upgrades kotlin to 1.6.10
  • Temporarily comments out usages of notification as a follow up PR will add the new integration w/ the Notification plugin that is being released in 2.0
  • Upgrades OpenSearch/dependencies to 2.0.0
  • Upgrades gradle to 7.3.3
  • Removes usages of _DOC type
  • Fixes breaking changes of internal API calls
  • Fixes styling issues
  • Updates CI to new version
  • Temporarily increase detekt issues to 20 as a bunch added for the commented out notification stuff which will get fixed in follow up PR.

Issues:
#303

CheckList:

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@dbbaughe dbbaughe requested a review from a team March 31, 2022 17:26
@dbbaughe
Copy link
Contributor Author

dbbaughe commented Mar 31, 2022

Looks like the mappings do not have the properties field in them anymore which is breaking the logic to check for the existence of a field in a mapping in rollups, will update the logic.

I guess that's not true... just the tests were passing in the mapping source to the MappingMetadata which was then using the "properties" key as the "type" and causing issues, it seems it still expects _doc to be passing in.

@codecov-commenter
Copy link

Codecov Report

Merging #318 (ca5d48f) into main (901d887) will increase coverage by 0.73%.
The diff coverage is 75.86%.

@@             Coverage Diff              @@
##               main     #318      +/-   ##
============================================
+ Coverage     75.73%   76.46%   +0.73%     
- Complexity     2003     2041      +38     
============================================
  Files           253      253              
  Lines         11467    11636     +169     
  Branches       1815     1807       -8     
============================================
+ Hits           8685     8898     +213     
- Misses         1751     1764      +13     
+ Partials       1031      974      -57     
Impacted Files Coverage Δ
...agement/indexstatemanagement/ManagedIndexRunner.kt 45.95% <0.00%> (-4.97%) ⬇️
...exstatemanagement/model/destination/Destination.kt 81.48% <ø> (+32.73%) ⬆️
...ement/step/notification/AttemptNotificationStep.kt 9.37% <0.00%> (-53.13%) ⬇️
...t/action/indexpolicy/TransportIndexPolicyAction.kt 80.55% <0.00%> (+3.41%) ⬆️
...ent/indexstatemanagement/util/ManagedIndexUtils.kt 77.83% <ø> (-0.48%) ⬇️
...ensearch/indexmanagement/rollup/model/ISMRollup.kt 96.52% <ø> (+1.78%) ⬆️
...ndexmanagement/transform/TransformSearchService.kt 67.81% <ø> (+2.13%) ⬆️
...ch/indexmanagement/transform/TransformValidator.kt 63.63% <50.00%> (+5.63%) ⬆️
...ensearch/indexmanagement/IndexManagementIndices.kt 63.21% <100.00%> (+2.50%) ⬆️
...ndexstatemanagement/IndexStateManagementHistory.kt 80.00% <100.00%> (-0.15%) ⬇️
... and 198 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 901d887...ca5d48f. Read the comment docs.

@dbbaughe dbbaughe merged commit b6e7d35 into opensearch-project:main Apr 1, 2022
@dbbaughe dbbaughe deleted the upgrade branch April 1, 2022 19:51
@dbbaughe dbbaughe mentioned this pull request Apr 5, 2022
3 tasks
wuychn pushed a commit to ochprince/index-management that referenced this pull request Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants