Disables detekt due to missing dependencies

[downsrob]

Signed-off-by: Robert Downs [email protected]

Issue #, if available:
#249

Description of changes:

• Removes detekt from index management 1.2
• Renames some transform and rollup ids in tests to reduce test flakiness which was preventing a successful build.

Following the jcenter sunset, the detekt dependency jcommander:1.74 is not available. This dependency was only present on jcenter, which cannot be relied on for build availability. Upgrading the dependency results in hundreds of new code smells, so detekt would need to be disabled after an upgrade anyways, unless those style issues were fixed. As code style issues should not go into the 1.2 branch at this time, removing the dependency on 1.2 is the best resolution.

CheckList:

• Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[codecov-commenter]

Codecov Report

Merging #250 (13a3541) into 1.2 (67499b5) will decrease coverage by 0.07%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                1.2     #250      +/-   ##
============================================
- Coverage     75.23%   75.16%   -0.08%     
- Complexity     1910     1915       +5     
============================================
  Files           260      260              
  Lines         11094    11094              
  Branches       1746     1746              
============================================
- Hits           8347     8339       -8     
- Misses         1794     1805      +11     
+ Partials        953      950       -3     

Impacted Files	Coverage Δ
...statemanagement/model/destination/CustomWebhook.kt	65.21% <0.00%> (-27.54%)	⬇️
...earch/indexmanagement/transform/model/Transform.kt	86.00% <0.00%> (-1.00%)	⬇️
...earch/indexmanagement/transform/TransformRunner.kt	84.04% <0.00%> (+1.06%)	⬆️
...xmanagement/rollup/actionfilter/FieldCapsFilter.kt	74.11% <0.00%> (+1.17%)	⬆️
...nt/rollup/action/stop/TransportStopRollupAction.kt	70.73% <0.00%> (+1.21%)	⬆️
...ensearch/indexmanagement/rollup/model/ISMRollup.kt	94.73% <0.00%> (+1.75%)	⬆️
...arch/indexmanagement/rollup/RollupSearchService.kt	61.11% <0.00%> (+1.85%)	⬆️
.../rollup/action/start/TransportStartRollupAction.kt	68.67% <0.00%> (+3.61%)	⬆️
...nt/indexstatemanagement/model/destination/Chime.kt	54.54% <0.00%> (+13.63%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 67499b5...13a3541. Read the comment docs.