Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support close action using new interface #224

Merged

Conversation

annie3431
Copy link
Contributor

@annie3431 annie3431 commented Dec 14, 2021

Signed-off-by: Annie Lee [email protected]

Issue #, if available:

Description of changes:
Adding code for Close action

CheckList:

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Annie Lee added 6 commits December 13, 2021 13:37
Signed-off-by: Annie Lee <[email protected]>
Signed-off-by: Annie Lee <[email protected]>
Since TransitionAction is not yet implemented. Marking a test as private to avoid integ test failure

Signed-off-by: Annie Lee <[email protected]>
Signed-off-by: Annie Lee <[email protected]>
@codecov-commenter
Copy link

Codecov Report

Merging #224 (83d886b) into development-extension (9aa8bde) will increase coverage by 0.23%.
The diff coverage is 87.50%.

Impacted file tree graph

@@                     Coverage Diff                     @@
##             development-extension     #224      +/-   ##
===========================================================
+ Coverage                    59.87%   60.11%   +0.23%     
- Complexity                    1312     1325      +13     
===========================================================
  Files                          249      249              
  Lines                         9338     9386      +48     
  Branches                      1437     1441       +4     
===========================================================
+ Hits                          5591     5642      +51     
+ Misses                        3072     3065       -7     
- Partials                       675      679       +4     
Impacted Files Coverage Δ
...t/indexstatemanagement/action/CloseActionParser.kt 71.42% <66.66%> (+71.42%) ⬆️
...agement/indexstatemanagement/action/CloseAction.kt 83.33% <75.00%> (+83.33%) ⬆️
...ndexstatemanagement/step/close/AttemptCloseStep.kt 91.30% <91.11%> (+91.30%) ⬆️
...anagement/indexstatemanagement/ISMActionsParser.kt 76.47% <100.00%> (+6.77%) ⬆️
...t/indexstatemanagement/model/ManagedIndexConfig.kt 74.28% <0.00%> (-2.86%) ⬇️
.../opensearch/indexmanagement/rollup/model/Rollup.kt 83.49% <0.00%> (-0.48%) ⬇️
...anagement/indexstatemanagement/model/Transition.kt 16.90% <0.00%> (ø)
...nsform/action/stop/TransportStopTransformAction.kt 72.15% <0.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9aa8bde...83d886b. Read the comment docs.

@annie3431 annie3431 changed the title Support close action Support close action using new interface Dec 14, 2021
@annie3431 annie3431 marked this pull request as ready for review December 14, 2021 01:45
Copy link
Contributor

@thalurur thalurur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like there are no ActionTests or xContentTets for Close Action - we should add these too either in this PR or a new PR

@annie3431 annie3431 merged commit 715ae2b into opensearch-project:development-extension Dec 16, 2021
downsrob pushed a commit to downsrob/index-management that referenced this pull request Mar 8, 2022
Signed-off-by: Ravi Thaluru <[email protected]>

Base commit to clean up old action interfaces and disabling all ISM related tests (opensearch-project#218)

Signed-off-by: Ravi Thaluru <[email protected]>

Implement DeleteAcion using new interface (opensearch-project#221)

Signed-off-by: Ravi Thaluru <[email protected]>

Adding base logic to transition step to enable policy execution (opensearch-project#223)

Signed-off-by: Ravi Thaluru <[email protected]>

Support close action using new interface (opensearch-project#224)

* Implement close action

Signed-off-by: Annie Lee <[email protected]>

* Update functions

Signed-off-by: Annie Lee <[email protected]>

* Update AttemptCloseStepTests.kt

Signed-off-by: Annie Lee <[email protected]>

* Mark a test as private for now

Since TransitionAction is not yet implemented. Marking a test as private to avoid integ test failure

Signed-off-by: Annie Lee <[email protected]>

* Update CloseActionIT.kt

Signed-off-by: Annie Lee <[email protected]>

Implement ReadOnlyAction using new interface (opensearch-project#227)

* Refactors ReadOnlyAction

Signed-off-by: Robert Downs <[email protected]>

Implement ReadWriteAction using new interface (opensearch-project#228)

Signed-off-by: Clay Downs <[email protected]>

Implement OpenAction using new interface (opensearch-project#230)

* Support open action

Signed-off-by: Annie Lee <[email protected]>

* Update AttemptOpenStep.kt

Signed-off-by: Annie Lee <[email protected]>

* Add close action test

Signed-off-by: Annie Lee <[email protected]>

* Add open action related tests

Signed-off-by: Annie Lee <[email protected]>

* Add open action test round trip

Signed-off-by: Annie Lee <[email protected]>

* Fix open action xcontent test

Signed-off-by: Annie Lee <[email protected]>

* Modify XContentTests for better comparison

Signed-off-by: Annie Lee <[email protected]>

* Update XContentTests.kt

Signed-off-by: Annie Lee <[email protected]>

Implements RolloverAction with new interface, fixes default action retry commit (opensearch-project#231)

* Implements rollover action with new interface, fixes default action retry

Signed-off-by: Clay Downs <[email protected]>

Support ReplicaCountAction using new interface (opensearch-project#233)

Signed-off-by: Annie Lee <[email protected]>

Refactors rollup action and enables multi step actions (opensearch-project#235)

Signed-off-by: Robert Downs <[email protected]>

Refactors Notification action with new interface (opensearch-project#238)

* Refactors notification action with new interface

Signed-off-by: Robert Downs <[email protected]>

Upgrades detekt version, fixes flaky tests (opensearch-project#254)

* Upgrades detekt version to 1.17.1 (opensearch-project#252)

* Adds detekt ignores to not-yet-refactored files

* Fixes flaky rollup/transform explain IT (opensearch-project#247)

Signed-off-by: Robert Downs <[email protected]>

Support force merge action using new interface (opensearch-project#256)

* Support force merge action

Signed-off-by: Annie Lee <[email protected]>

Refactors Snapshot action to use new interface (opensearch-project#253)

* Refactors snapshot action to use new interface

Signed-off-by: Clay Downs <[email protected]>

Support index priority action using new interface (opensearch-project#257)

Signed-off-by: Annie Lee <[email protected]>

Support Allocation action using new interface (opensearch-project#246)

* Support Allocation action using new interface

Signed-off-by: Annie Lee <[email protected]>

* Pass in required parameter

Signed-off-by: Annie Lee <[email protected]>

* Update AttemptAllocationStep.kt

Adding correct const

Signed-off-by: Annie Lee <[email protected]>

* Update AttemptAllocationStep.kt

Typo in message

Signed-off-by: Annie Lee <[email protected]>

* Debug tests

Signed-off-by: Annie Lee <[email protected]>

* Update XContentTests.kt

Signed-off-by: Annie Lee <[email protected]>

* Revert "Debug tests"

This reverts commit d7123bd.

Signed-off-by: Annie Lee <[email protected]>

* Update IndexPolicyRequestTests.kt

Signed-off-by: Annie Lee <[email protected]>

* Support force merge action using new interface (opensearch-project#256)

* Support force merge action

Signed-off-by: Annie Lee <[email protected]>

* Update AllocationActionIT.kt

Signed-off-by: Annie Lee <[email protected]>

* Revert "Update IndexPolicyRequestTests.kt"

This reverts commit bd34e2e.

Signed-off-by: Annie Lee <[email protected]>

* Add debug log

Signed-off-by: Annie Lee <[email protected]>

* Remove debug log and change order of parameters

Signed-off-by: Annie Lee <[email protected]>

* Update after comments

Fix order of include exclude parameter in parser
Add check to tests
Remove "Config" in message

Signed-off-by: Annie Lee <[email protected]>

Merging changes from main branch (opensearch-project#259)

Signed-off-by: Ravi Thaluru <[email protected]>

merge with main (opensearch-project#270)

Signed-off-by: Ravi Thaluru <[email protected]>

Adds custom action parsing (opensearch-project#273)

* Adds custom action parsing logic

Signed-off-by: Robert Downs <[email protected]>

Refactor coordinator to support create and delete index events when different index types exist on cluster (opensearch-project#272)

* Refactor coordinator to support different index type create and delete events and sweep

Signed-off-by: Ravi Thaluru <[email protected]>

introducing custom uuid setting in SPI (opensearch-project#278)

* introducing custom uuid setting in SPI

Signed-off-by: Ravi Thaluru <[email protected]>

Refactors the managed index runner to work with extensions (opensearch-project#262)

* Adds index creation date

Signed-off-by: Robert Downs <[email protected]>

Adds NewClusterEventListeners and refactors Transition to work with custom actions

Signed-off-by: Robert Downs <[email protected]>

Marks blocked actions list as deprecated

Signed-off-by: Clay Downs <[email protected]>

Asserts the deprecation warning after adding to allow list in test

Signed-off-by: Robert Downs <[email protected]>

Removes allow_list test

Signed-off-by: Robert Downs <[email protected]>

* Fix additional rebase issues

Signed-off-by: Robert Downs <[email protected]>

* Fixes failing tests

Signed-off-by: Robert Downs <[email protected]>

* changes based on comments

Signed-off-by: Robert Downs <[email protected]>

* Adds additional comments

Signed-off-by: Clay Downs <[email protected]>

Makes rest APIs use new metadata service (opensearch-project#245)

* Makes rest API use new metadata service

Signed-off-by: Robert Downs <[email protected]>

Adds missed flags (opensearch-project#286)

Signed-off-by: Clay Downs <[email protected]>

Ports over show-applied-policies logic (opensearch-project#287)

Signed-off-by: Clay Downs <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants