Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds default action retries #212

Merged
merged 1 commit into from
Dec 3, 2021

Conversation

dbbaughe
Copy link
Contributor

@dbbaughe dbbaughe commented Dec 3, 2021

Signed-off-by: Drew Baugher [email protected]

Description of changes:
Adds default retries of 3 to all ISM actions.
Reduces the required retry number to >= 0 instead of > 0 to allow users to choose 0 retries if they want that.
Fixes some tests that failed because of the change which were relying on the job failing.
Fixes a flaky test that tried deleting data stream backed indices using the wipeAllODFEIndices method, it'll first delete data stream backed indices before the next call for other indices.

CheckList:

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Drew Baugher <[email protected]>
@codecov-commenter
Copy link

Codecov Report

Merging #212 (5ab03de) into main (c739190) will decrease coverage by 0.10%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #212      +/-   ##
============================================
- Coverage     76.03%   75.92%   -0.11%     
+ Complexity     1938     1930       -8     
============================================
  Files           260      260              
  Lines         11094    11094              
  Branches       1746     1746              
============================================
- Hits           8435     8423      -12     
- Misses         1704     1711       +7     
- Partials        955      960       +5     
Impacted Files Coverage Δ
.../indexstatemanagement/model/action/ActionConfig.kt 84.61% <100.00%> (ø)
...t/indexstatemanagement/model/action/ActionRetry.kt 82.75% <100.00%> (ø)
...nt/indexstatemanagement/model/destination/Chime.kt 40.90% <0.00%> (-13.64%) ⬇️
...ent/rollup/action/explain/ExplainRollupResponse.kt 75.00% <0.00%> (-10.00%) ⬇️
.../rollup/action/start/TransportStartRollupAction.kt 65.06% <0.00%> (-3.62%) ⬇️
...rch/indexmanagement/rollup/model/RollupMetadata.kt 82.73% <0.00%> (-1.79%) ⬇️
...nt/rollup/action/stop/TransportStopRollupAction.kt 69.51% <0.00%> (-1.22%) ⬇️
...management/indexstatemanagement/MetadataService.kt 60.86% <0.00%> (-1.09%) ⬇️
...nt/indexstatemanagement/ManagedIndexCoordinator.kt 71.77% <0.00%> (-1.05%) ⬇️
.../opensearch/indexmanagement/rollup/model/Rollup.kt 83.96% <0.00%> (-0.48%) ⬇️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c739190...5ab03de. Read the comment docs.

@dbbaughe dbbaughe merged commit 36e9d76 into opensearch-project:main Dec 3, 2021
@dbbaughe dbbaughe deleted the defaultretries branch December 3, 2021 22:43
@ohltyler ohltyler mentioned this pull request Feb 1, 2022
downsrob pushed a commit to downsrob/index-management that referenced this pull request Mar 9, 2022
downsrob pushed a commit to downsrob/index-management that referenced this pull request Mar 9, 2022
Signed-off-by: Drew Baugher <[email protected]>
Signed-off-by: Robert Downs <[email protected]>
downsrob pushed a commit that referenced this pull request Mar 9, 2022
Signed-off-by: Drew Baugher <[email protected]>
Signed-off-by: Robert Downs <[email protected]>
wuychn pushed a commit to ochprince/index-management that referenced this pull request Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants