Successful deletes of an index still adds history document #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #160 +/- ##
============================================
+ Coverage 75.83% 75.96% +0.13%
- Complexity 1924 1933 +9
============================================
Files 260 260
Lines 11002 11096 +94
Branches 1723 1746 +23
============================================
+ Hits 8343 8429 +86
- Misses 1707 1711 +4
- Partials 952 956 +4
Continue to review full report at Codecov.
|
thalurur
pushed a commit
to thalurur/open-index-management
that referenced
this pull request
Oct 22, 2021
thalurur
reviewed
Dec 3, 2021
src/test/kotlin/org/opensearch/indexmanagement/indexstatemanagement/action/DeleteActionIT.kt
Outdated
Show resolved
Hide resolved
thalurur
previously approved these changes
Dec 3, 2021
thalurur
previously approved these changes
Dec 3, 2021
Signed-off-by: Drew Baugher <[email protected]>
dbbaughe
force-pushed
the
deletehistory
branch
from
7cafc6a to
bb5b2ed
Compare
thalurur
approved these changes
Dec 3, 2021
downsrob
approved these changes
Dec 3, 2021
downsrob
pushed a commit
to downsrob/index-management
that referenced
this pull request
Mar 9, 2022
…h-project#160) Signed-off-by: Drew Baugher <[email protected]>
downsrob
pushed a commit
to downsrob/index-management
that referenced
this pull request
Mar 9, 2022
…h-project#160) Signed-off-by: Drew Baugher <[email protected]> Signed-off-by: Robert Downs <[email protected]>
downsrob
pushed a commit
that referenced
this pull request
Mar 9, 2022
Signed-off-by: Drew Baugher <[email protected]> Signed-off-by: Robert Downs <[email protected]>
wuychn
pushed a commit
to ochprince/index-management
that referenced
this pull request
Mar 16, 2023
…h-project#160) Signed-off-by: Drew Baugher <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Drew Baugher [email protected]
Issue #, if available:
#159
Description of changes:
Previously when an index was successfully deleted by ISM it would just return early without adding a history document. This fixes that so we can see the successful delete in the history indices.
CheckList:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.