Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add publish in spi build.gradle #1207

Merged
merged 4 commits into from
Jul 19, 2024

Conversation

bowenlan-amzn
Copy link
Member

@bowenlan-amzn bowenlan-amzn commented Jul 17, 2024

Description

Publish the spi to maven

Can be consumed as compileOnly "org.opensearch:opensearch-index-management-spi:${opensearch_version}"

Example commit of extend ISM opensearch-project/cross-cluster-replication@3853901

Test

Test locally by running ./gradlew publishShadowPublicationToStagingRepository

image

Reference
opensearch-project/alerting#1562
opensearch-project/alerting#1604
https://github.com/opensearch-project/opensearch-plugins/blob/main/BUILDING.md#include-checksums-in-maven-publications

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: bowenlan-amzn <[email protected]>
@prudhvigodithi
Copy link
Member

prudhvigodithi commented Jul 18, 2024

Thanks @bowenlan-amzn can you please also confirm if there is no change in publishing of the zip file ?

<groupId>org.opensearch.plugin</groupId>
<artifactId>opensearch-index-management</artifactId>
<version>2.16.0.0-SNAPSHOT</version>
<packaging>zip</packaging>

https://aws.oss.sonatype.org/content/repositories/snapshots/org/opensearch/plugin/opensearch-index-management/

@bowenlan-amzn
Copy link
Member Author

Thanks @bowenlan-amzn can you please also confirm if there is no change in publishing of the zip file ?

<groupId>org.opensearch.plugin</groupId>
<artifactId>opensearch-index-management</artifactId>
<version>2.16.0.0-SNAPSHOT</version>
<packaging>zip</packaging>

aws.oss.sonatype.org/content/repositories/snapshots/org/opensearch/plugin/opensearch-index-management

I run publishPluginZipPublicationToZipStagingRepository, and here's the result, it looks good to me

image

@prudhvigodithi and a quick question, do we need to backport this to any branch other than 2.x?

@prudhvigodithi
Copy link
Member

Thanks @bowenlan-amzn, ya as long as there no change in publishing of the zip file we should be good, also just 2.x as the gradle custom plugin used opensearch.pluginzip is only available starting 2.x. https://opensearch.org/blog/opensearch-plugin-zips-now-in-maven-repo/
Thank you

@bowenlan-amzn bowenlan-amzn merged commit 214aae5 into opensearch-project:main Jul 19, 2024
25 of 29 checks passed
@bowenlan-amzn bowenlan-amzn deleted the publish-spi branch July 19, 2024 23:55
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 19, 2024
(cherry picked from commit 214aae5)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants