[Backport 2.8] Implemented alias action UX. #781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
* Implemented UX component for configuring and editing alias actions. Signed-off-by: AWSHurneyt <[email protected]> * Implemented unit and integration tests for alias action UX. Signed-off-by: AWSHurneyt <[email protected]> * Refactored existing test to accommodate addition of alias action UX. Signed-off-by: AWSHurneyt <[email protected]> * Fixed a bug preventing validation messages from appearing under both combo boxes at once. Signed-off-by: AWSHurneyt <[email protected]> * Removed redundant 'popout' icons from 'Learn more' links. Having 'target="_blank"' in the link attributes provides the icon. Updated snapshots. Signed-off-by: AWSHurneyt <[email protected]> * Added unit tests for AliasUiAction. Signed-off-by: AWSHurneyt <[email protected]> * Refactored alias action UX to include toggles to hide/display the add/remove combo boxes. Implemented a modal to confirm clearing combo box entries when toggling display. Signed-off-by: AWSHurneyt <[email protected]> * Refactored UX to remove the alias combo box clear confirmation modal based on PR feedback. Signed-off-by: AWSHurneyt <[email protected]> * Updated the 2.8 release notes. Signed-off-by: AWSHurneyt <[email protected]> --------- Signed-off-by: AWSHurneyt <[email protected]> (cherry picked from commit 5f5a172)
Codecov Report
@@ Coverage Diff @@
## 2.8 #781 +/- ##
==========================================
+ Coverage 62.37% 63.40% +1.03%
==========================================
Files 337 340 +3
Lines 11437 11541 +104
Branches 2212 2239 +27
==========================================
+ Hits 7134 7318 +184
+ Misses 3739 3649 -90
- Partials 564 574 +10 |
SuZhou-Joe
approved these changes
May 31, 2023
bowenlan-amzn
approved these changes
May 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 5f5a172 from #754