Tune the column width, fix the problem of showing snapshot failures #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: bowenlan-amzn <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #210 +/- ##
==========================================
- Coverage 51.58% 51.54% -0.05%
==========================================
Files 183 183
Lines 5798 5803 +5
Branches 934 934
==========================================
Hits 2991 2991
- Misses 2586 2591 +5
Partials 221 221
Continue to review full report at Codecov.
|
AWSHurneyt
reviewed
Jun 29, 2022
There was a problem hiding this comment.
Small observation.
I just noticed that when the EuiFlyout element is created, it doesn't have type={'push'}. The mocks seem to illustrate an overlay type, but that might just be a small oversight; during the doc level monitor UX meetings, we were told that the push type is preferred.
AWSHurneyt
approved these changes
Jun 29, 2022
downsrob
approved these changes
Jun 29, 2022
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jun 29, 2022
…210) Signed-off-by: bowenlan-amzn <[email protected]> (cherry picked from commit e82d77f)
bowenlan-amzn
added a commit
that referenced
this pull request
Jun 29, 2022
…210) (#211) Signed-off-by: bowenlan-amzn <[email protected]> (cherry picked from commit e82d77f) Co-authored-by: bowenlan-amzn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: bowenlan-amzn [email protected]
Description
[Describe what this change achieves]
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.