MDS Support for Policies, Policy Managed Indices, Rollup Jobs and Transform Jobs #1021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CaptainDredge
requested review from
amsiglan,
AWSHurneyt,
bowenlan-amzn,
getsaurabh02,
praveensameneni,
xluo-aws,
gaobinlong,
Hailong-am,
SuZhou-Joe,
lezzago,
sbcd90,
eirsep,
r1walz and
vikasvb90
as code owners
…ollup jobs Signed-off-by: Prabhat Sharma <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1021 +/- ##
==========================================
- Coverage 63.43% 63.20% -0.24%
==========================================
Files 344 344
Lines 11668 11833 +165
Branches 2260 2315 +55
==========================================
+ Hits 7402 7479 +77
- Misses 3689 3734 +45
- Partials 577 620 +43 ☔ View full report in Codecov by Sentry. |
|
@SuZhou-Joe , @BionIT Please review the PR |
public/pages/ChangePolicy/containers/ChangePolicy/ChangePolicy.tsx
Outdated
Show resolved
Hide resolved
public/pages/CreateRollup/containers/CreateRollupForm/CreateRollupForm.tsx
Outdated
Show resolved
Hide resolved
public/pages/CreateTransform/containers/CreateTransformForm/CreateTransformForm.tsx
Show resolved
Hide resolved
public/pages/ManagedIndices/containers/ManagedIndices/ManagedIndices.tsx
Outdated
Show resolved
Hide resolved
public/pages/ManagedIndices/containers/ManagedIndices/ManagedIndices.tsx
Outdated
Show resolved
Hide resolved
BionIT
reviewed
Apr 4, 2024
public/pages/CreateRollup/containers/CreateRollupForm/CreateRollupForm.tsx
Outdated
Show resolved
Hide resolved
public/pages/CreateRollup/containers/CreateRollupForm/CreateRollupForm.tsx
Show resolved
Hide resolved
public/pages/CreateRollup/containers/CreateRollupForm/CreateRollupForm.tsx
Outdated
Show resolved
Hide resolved
public/pages/ChangePolicy/containers/ChangePolicy/ChangePolicy.tsx
Outdated
Show resolved
Hide resolved
added 4 commits
April 5, 2024 16:02
Signed-off-by: Prabhat Sharma <[email protected]>
Signed-off-by: Prabhat Sharma <[email protected]>
Signed-off-by: Prabhat Sharma <[email protected]>
Signed-off-by: Prabhat Sharma <[email protected]>
SuZhou-Joe
previously approved these changes
Apr 6, 2024
public/pages/ChangePolicy/containers/ChangePolicy/ChangePolicy.tsx
Outdated
Show resolved
Hide resolved
Signed-off-by: Prabhat Sharma <[email protected]>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Apr 8, 2024
…nsform Jobs (#1021) * Add MDS support for policies, policy managed indices, transform and rollup jobs Signed-off-by: Prabhat Sharma <[email protected]> * Addressed PR comments Signed-off-by: Prabhat Sharma <[email protected]> * Fixed tests Signed-off-by: Prabhat Sharma <[email protected]> * Address few more comments Signed-off-by: Prabhat Sharma <[email protected]> * Minor fix Signed-off-by: Prabhat Sharma <[email protected]> * Address minor comment Signed-off-by: Prabhat Sharma <[email protected]> --------- Signed-off-by: Prabhat Sharma <[email protected]> Co-authored-by: Prabhat Sharma <[email protected]> (cherry picked from commit 07c68ec) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
SuZhou-Joe
pushed a commit
that referenced
this pull request
Apr 9, 2024
…nsform Jobs (#1021) * Add MDS support for policies, policy managed indices, transform and rollup jobs Signed-off-by: Prabhat Sharma <[email protected]> * Addressed PR comments Signed-off-by: Prabhat Sharma <[email protected]> * Fixed tests Signed-off-by: Prabhat Sharma <[email protected]> * Address few more comments Signed-off-by: Prabhat Sharma <[email protected]> * Minor fix Signed-off-by: Prabhat Sharma <[email protected]> * Address minor comment Signed-off-by: Prabhat Sharma <[email protected]> --------- Signed-off-by: Prabhat Sharma <[email protected]> Co-authored-by: Prabhat Sharma <[email protected]> (cherry picked from commit 07c68ec) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
SuZhou-Joe
pushed a commit
that referenced
this pull request
Apr 12, 2024
…nsform Jobs (#1021) (#1025) * Add MDS support for policies, policy managed indices, transform and rollup jobs * Addressed PR comments * Fixed tests * Address few more comments * Minor fix * Address minor comment --------- (cherry picked from commit 07c68ec) Signed-off-by: Prabhat Sharma <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Prabhat Sharma <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds MDS support for the remaining index management pages
Issues Resolved
Resolves #982
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.