specify _all as target in ClearCacheModal #1020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r1walz
requested review from
amsiglan,
AWSHurneyt,
bowenlan-amzn,
getsaurabh02,
praveensameneni,
xluo-aws,
gaobinlong,
Hailong-am,
SuZhou-Joe,
lezzago,
sbcd90,
eirsep and
vikasvb90
as code owners
When none of the indices are selected, ClearCacheModal makes call to `//_cache/clear` path. Here, the intention is to clear the cache for all indices, let's make it explicit by passing `_all` as target. New call: `/_all/_cache/clear` Signed-off-by: Rohit Ashiwal <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1020 +/- ##
=======================================
Coverage 63.43% 63.44%
=======================================
Files 344 344
Lines 11668 11669 +1
Branches 2260 2261 +1
=======================================
+ Hits 7402 7403 +1
Misses 3689 3689
Partials 577 577 ☔ View full report in Codecov by Sentry. |
CaptainDredge
approved these changes
Mar 28, 2024
khushbr
approved these changes
Apr 3, 2024
vikasvb90
approved these changes
Apr 9, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Apr 9, 2024
When none of the indices are selected, ClearCacheModal makes call to `//_cache/clear` path. Here, the intention is to clear the cache for all indices, let's make it explicit by passing `_all` as target. New call: `/_all/_cache/clear` Signed-off-by: Rohit Ashiwal <[email protected]> (cherry picked from commit 134f23f) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
CaptainDredge
pushed a commit
to CaptainDredge/index-management-dashboards-plugin
that referenced
this pull request
Apr 11, 2024
When none of the indices are selected, ClearCacheModal makes call to `//_cache/clear` path. Here, the intention is to clear the cache for all indices, let's make it explicit by passing `_all` as target. New call: `/_all/_cache/clear` Signed-off-by: Rohit Ashiwal <[email protected]>
r1walz
pushed a commit
that referenced
this pull request
May 21, 2024
When none of the indices are selected, ClearCacheModal makes call to `//_cache/clear` path. Here, the intention is to clear the cache for all indices, let's make it explicit by passing `_all` as target. New call: `/_all/_cache/clear` Signed-off-by: Rohit Ashiwal <[email protected]> (cherry picked from commit 134f23f) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
r1walz
pushed a commit
that referenced
this pull request
May 21, 2024
When none of the indices are selected, ClearCacheModal makes call to `//_cache/clear` path. Here, the intention is to clear the cache for all indices, let's make it explicit by passing `_all` as target. New call: `/_all/_cache/clear` (cherry picked from commit 134f23f) Signed-off-by: Rohit Ashiwal <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When none of the indices are selected, ClearCacheModal makes call to
//_cache/clearpath. Here, the intention is to clear the cache for all indices, let's make it explicit by passing_allas target.New call:
/_all/_cache/clearIssues Resolved
N/A
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.