Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cypress: modify test to check for inequality #1017

Merged
merged 1 commit into from
May 21, 2024

Conversation

r1walz
Copy link
Contributor

@r1walz r1walz commented Mar 26, 2024

Description

When testing against cluster with more than one node, we encounter that this check fails as total number of uncommitted operations will be as per replica configuration. Eg. for a 1:1 pri:rep case, total number of uncommitted operations will be two (one for primary, one for replica). Let's change the check to check for inequality instead.

Issues Resolved

N/A

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

codecov bot commented Mar 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.43%. Comparing base (b151b85) to head (6f5d685).
Report is 9 commits behind head on main.

Current head 6f5d685 differs from pull request most recent head 2182b79

Please upload reports for the commit 2182b79 to get more accurate results.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1017   +/-   ##
=======================================
  Coverage   63.43%   63.43%           
=======================================
  Files         344      344           
  Lines       11668    11668           
  Branches     2260     2260           
=======================================
  Hits         7402     7402           
  Misses       3689     3689           
  Partials      577      577           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bowenlan-amzn bowenlan-amzn merged commit 2bcb2a5 into opensearch-project:main May 21, 2024
9 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request May 21, 2024
(cherry picked from commit 2bcb2a5)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@r1walz r1walz deleted the inequality branch May 21, 2024 15:29
r1walz pushed a commit that referenced this pull request May 22, 2024
(cherry picked from commit 2bcb2a5)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants