Bump to opensearch-dashboards-1.3.1 App Version in helm release chart version 1.4.0

[abhinavGupta16]

Signed-off-by: Abhinav Gupta [email protected]

Description

Added changelog for 1.3.1 opensearch-dashboards release

Issues Resolved

opensearch-project/opensearch-build#1885

Check List

• Commits are signed per the DCO using --signoff

For any changes to files within Helm chart directories:

• Helm chart version bumped
• Helm chart CHANGELOG.md updated to reflect change

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[prudhvigodithi]

Hey @abhinavGupta16 please change appVersion, to point to the latest version for dashboard.

[peterzhuamazon]

This is new release means minor bump

[sastorsl]

Could the title of this PR be updated to reflect show that the actual version bump is the appVersion?
"Bump to opensearch-dashboards-1.3-1 in helm release 1.4.0" for instance?

[TheAlgo]

I agree with @sastorsl this commit message is not so good even if the version number was correct. Here the intent is to not add CHANGELOG but bump the version.

IMHO I don't prefer commits which has a past tense (Eg : Bumped , Added). If we see the default git commit those are always like commands (Eg : Merge abc from cde)

[TheAlgo]

Also @abhinavGupta16 in the issue attached I could find the details regarding helm update. There is no mention about the release in helm charts

[abhinavGupta16]

I agree with @sastorsl this commit message is not so good even if the version number was correct. Here the intent is to not add CHANGELOG but bump the version.

IMHO I don't prefer commits which has a past tense (Eg : Bumped , Added). If we see the default git commit those are always like commands (Eg : Merge abc from cde)

Well, I don't think tense matters as long as the message is conveyed.

[abhinavGupta16]

Could the title of this PR be updated to reflect show that the actual version bump is the appVersion? "Bump to opensearch-dashboards-1.3-1 in helm release 1.4.0" for instance?

Good suggestion. I updated the title. It would make it easier to search for the PR

[TheAlgo]

Could the title of this PR be updated to reflect show that the actual version bump is the appVersion? "Bump to opensearch-dashboards-1.3-1 in helm release 1.4.0" for instance?

Good suggestion. I updated the title. It would make it easier to search for the PR

@abhinavGupta16 Do you mind changing to Bump appversion to 1.3.1 or Change default version to 1.3.1 instead of added changelog?

[TheAlgo]

@abhinavGupta16 Any update on this?

[peterzhuamazon]

I changed it.

 Bump to opensearch-dashboards-1.3.1 App Version in helm release chart version 1.4.0

Thanks @sastorsl @TheAlgo

[sastorsl]

Well, I don't think tense matters as long as the message is conveyed.

It's a frequent discussion topic, and of course opinions matter on this subject.
If git itself can be a guide it mentions this in its documentation, and favours the "imperative" / present tense style.

The most important though is that it is maintained throughout the project, so I would suggest that the OpenSearch-team opens this up for discussion in a separate issue and make a decision.

More importantly, thank you for updating the title :-)