Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Adds Register and Deploy Model Step for remote model #85

Merged
merged 1 commit into from
Oct 13, 2023

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 9b10b23 from #52.

* Initial UploadModel integration

Signed-off-by: Owais Kazi <[email protected]>

* Implemented Register Model Step

Signed-off-by: Owais Kazi <[email protected]>

* Integrated register for remote model

Signed-off-by: Owais Kazi <[email protected]>

* Integrated deploy model

Signed-off-by: Owais Kazi <[email protected]>

* Separated Register and Deploy Steps

Signed-off-by: Owais Kazi <[email protected]>

* Added tests

Signed-off-by: Owais Kazi <[email protected]>

* Added NodeClient

Signed-off-by: Owais Kazi <[email protected]>

* Added javadocs

Signed-off-by: Owais Kazi <[email protected]>

* Addressed PR comments

Signed-off-by: Owais Kazi <[email protected]>

* Addressed PR comments

Signed-off-by: Owais Kazi <[email protected]>

* Addressed PR comments - 2

Signed-off-by: Owais Kazi <[email protected]>

* Fixed test failure

Signed-off-by: Owais Kazi <[email protected]>

* Addressed PR comments

Signed-off-by: Owais Kazi <[email protected]>

---------

Signed-off-by: Owais Kazi <[email protected]>
(cherry picked from commit 9b10b23)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@owaiskazi19
Copy link
Member

opensearch-project/ml-commons#1388 needs to be backported to 2.x of ml-commons to get a successful build.

@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

Merging #85 (5e2af53) into 2.x (5141efb) will decrease coverage by 2.36%.
The diff coverage is 60.82%.

@@             Coverage Diff              @@
##                2.x      #85      +/-   ##
============================================
- Coverage     84.09%   81.74%   -2.36%     
- Complexity      197      211      +14     
============================================
  Files            18       21       +3     
  Lines           742      838      +96     
  Branches         90       96       +6     
============================================
+ Hits            624      685      +61     
- Misses           88      119      +31     
- Partials         30       34       +4     
Files Coverage Δ
.../org/opensearch/flowframework/client/MLClient.java 100.00% <100.00%> (+100.00%) ⬆️
...g/opensearch/flowframework/common/CommonValue.java 66.66% <ø> (ø)
...ch/flowframework/workflow/WorkflowStepFactory.java 68.42% <100.00%> (+3.71%) ⬆️
...search/flowframework/workflow/DeployModelStep.java 65.21% <65.21%> (ø)
...org/opensearch/flowframework/workflow/GetTask.java 0.00% <0.00%> (ø)
...arch/flowframework/workflow/RegisterModelStep.java 73.21% <73.21%> (ø)

@owaiskazi19
Copy link
Member

Created #87 for the flaky test

@owaiskazi19 owaiskazi19 merged commit 654065c into 2.x Oct 13, 2023
15 of 18 checks passed
@github-actions github-actions bot deleted the backport/backport-52-to-2.x branch October 13, 2023 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant