Register system index descriptors through SystemIndexPlugin.getSystemIndexDescriptors #750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…IndexDescriptors Signed-off-by: Craig Perkins <[email protected]>
cwperks
requested review from
dbwiddis,
owaiskazi19,
joshpalis,
ohltyler,
amitgalitz and
jackiehanyang
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #750 +/- ##
============================================
+ Coverage 74.29% 74.37% +0.08%
- Complexity 744 745 +1
============================================
Files 84 84
Lines 3824 3825 +1
Branches 333 333
============================================
+ Hits 2841 2845 +4
+ Misses 829 825 -4
- Partials 154 155 +1 ☔ View full report in Codecov by Sentry. |
dbwiddis
approved these changes
Jun 24, 2024
Signed-off-by: Craig Perkins <[email protected]>
|
@dbwiddis Added to the CHANGELOG |
shikharj05
approved these changes
Jun 26, 2024
Signed-off-by: Craig Perkins <[email protected]>
|
Addressed the spotless failure |
dbwiddis
reviewed
Jun 26, 2024
src/main/java/org/opensearch/flowframework/FlowFrameworkPlugin.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Craig Perkins <[email protected]>
shikharj05
approved these changes
Jul 1, 2024
|
Can a maintainer merge this PR? |
joshpalis
approved these changes
Jul 1, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 1, 2024
…IndexDescriptors (#750) * Register system index descriptors through SystemIndexPlugin.getSystemIndexDescriptors Signed-off-by: Craig Perkins <[email protected]> * Add CHANGELOG entry Signed-off-by: Craig Perkins <[email protected]> * Remove extra characters Signed-off-by: Craig Perkins <[email protected]> * Address code review comments Signed-off-by: Craig Perkins <[email protected]> --------- Signed-off-by: Craig Perkins <[email protected]> (cherry picked from commit cf1016f) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
joshpalis
pushed a commit
that referenced
this pull request
Jul 1, 2024
…lugin.getSystemIndexDescriptors (#753) Register system index descriptors through SystemIndexPlugin.getSystemIndexDescriptors (#750) * Register system index descriptors through SystemIndexPlugin.getSystemIndexDescriptors * Add CHANGELOG entry * Remove extra characters * Address code review comments --------- (cherry picked from commit cf1016f) Signed-off-by: Craig Perkins <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR registers the system indices in this plugin through the SystemIndexPlugin extension point in core. These indices will not be functionally different than they are today, its just a formal registration as a system index.
Issues Resolved
Related to opensearch-project/security#4439
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.