-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding additional default use cases #731
Adding additional default use cases #731
Conversation
7ce4099
to
bca3abe
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #731 +/- ##
============================================
- Coverage 74.41% 74.35% -0.06%
Complexity 744 744
============================================
Files 84 84
Lines 3811 3822 +11
Branches 330 333 +3
============================================
+ Hits 2836 2842 +6
- Misses 823 825 +2
- Partials 152 155 +3 ☔ View full report in Codecov by Sentry. |
Interesting that the windows single node integration tests are failing due to :
Looking at the test, its failing during this line : Can we use a smaller model here for this test? I think that should help mitigate the flakiness. Edit : |
Signed-off-by: Amit Galitzky <[email protected]>
Signed-off-by: Amit Galitzky <[email protected]>
c7b533e
to
1f9d215
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At a high level LGTM.
Signed-off-by: Amit Galitzky <[email protected]>
81e761e
to
50b44eb
Compare
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/flow-framework/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/flow-framework/backport-2.x
# Create a new branch
git switch --create backport/backport-731-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 53126cbe1a7b6bb6bf41196039b811d5436328a5
# Push it to GitHub
git push --set-upstream origin backport/backport-731-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/flow-framework/backport-2.x Then, create a pull request where the |
* adding pretrained model templates Signed-off-by: Amit Galitzky <[email protected]> * adding reindex Signed-off-by: Amit Galitzky <[email protected]> * changing file structure for bwc Signed-off-by: Amit Galitzky <[email protected]> --------- Signed-off-by: Amit Galitzky <[email protected]>
Adding additional default use cases (#731) * adding pretrained model templates * adding reindex * changing file structure for bwc --------- Signed-off-by: Amit Galitzky <[email protected]>
Description
id
field from some of the use case templatesIssues Resolved
part of #666
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.