-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add model interface support for remote and local custom models #701
Conversation
Signed-off-by: Joshua Palis <[email protected]>
Signed-off-by: Joshua Palis <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #701 +/- ##
============================================
- Coverage 74.56% 74.44% -0.13%
- Complexity 735 738 +3
============================================
Files 83 83
Lines 3708 3741 +33
Branches 318 322 +4
============================================
+ Hits 2765 2785 +20
- Misses 800 811 +11
- Partials 143 145 +2 ☔ View full report in Codecov by Sentry. |
src/main/java/org/opensearch/flowframework/common/CommonValue.java
Outdated
Show resolved
Hide resolved
…INTERFACE to INTERFACE_FIELD, adding parse util test Signed-off-by: Joshua Palis <[email protected]>
Instead of relaying on customer to escape strings and having to figure out how to give that user input we can use |
ignore this comment :) |
Signed-off-by: Joshua Palis <[email protected]>
* Add model interface support for remote and local custom models Signed-off-by: Joshua Palis <[email protected]> * Adding changelog and javadocs Signed-off-by: Joshua Palis <[email protected]> * Addressing PR comments, adding to 2.14 release notes, updating MODEL_INTERFACE to INTERFACE_FIELD, adding parse util test Signed-off-by: Joshua Palis <[email protected]> * updating RegisterRemoteModelStepTests Signed-off-by: Joshua Palis <[email protected]> --------- Signed-off-by: Joshua Palis <[email protected]> (cherry picked from commit 3318d31) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* Add model interface support for remote and local custom models Signed-off-by: Joshua Palis <[email protected]> * Adding changelog and javadocs Signed-off-by: Joshua Palis <[email protected]> * Addressing PR comments, adding to 2.14 release notes, updating MODEL_INTERFACE to INTERFACE_FIELD, adding parse util test Signed-off-by: Joshua Palis <[email protected]> * updating RegisterRemoteModelStepTests Signed-off-by: Joshua Palis <[email protected]> --------- Signed-off-by: Joshua Palis <[email protected]> (cherry picked from commit 3318d31) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…m models (#703) Add model interface support for remote and local custom models (#701) * Add model interface support for remote and local custom models * Adding changelog and javadocs * Addressing PR comments, adding to 2.14 release notes, updating MODEL_INTERFACE to INTERFACE_FIELD, adding parse util test * updating RegisterRemoteModelStepTests --------- (cherry picked from commit 3318d31) Signed-off-by: Joshua Palis <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…om models (#704) Add model interface support for remote and local custom models (#701) * Add model interface support for remote and local custom models * Adding changelog and javadocs * Addressing PR comments, adding to 2.14 release notes, updating MODEL_INTERFACE to INTERFACE_FIELD, adding parse util test * updating RegisterRemoteModelStepTests --------- (cherry picked from commit 3318d31) Signed-off-by: Joshua Palis <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Description
Adds support for the
interface
field of model registration. Currently only adding support for theregister_remote_model
andregister_local_custom_model
since pretrained/ local sparse encoding models do not currently work with the model interface.Registering and deploying remote model with model interface :
For registering and deploying local custom model :
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.