Fixing model group parsing and restoring context #695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Amit Galitzky <[email protected]>
amitgalitz
requested review from
dbwiddis,
owaiskazi19,
joshpalis,
ohltyler and
jackiehanyang
as code owners
|
looking at failing tests |
dbwiddis
reviewed
May 1, 2024
src/main/java/org/opensearch/flowframework/workflow/RegisterModelGroupStep.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/flowframework/transport/CreateWorkflowTransportAction.java
Show resolved
Hide resolved
What is the type of the ( |
owaiskazi19
reviewed
May 1, 2024
Signed-off-by: Amit Galitzky <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #695 +/- ##
============================================
- Coverage 73.78% 73.74% -0.04%
Complexity 722 722
============================================
Files 82 82
Lines 3662 3668 +6
Branches 312 315 +3
============================================
+ Hits 2702 2705 +3
- Misses 818 820 +2
- Partials 142 143 +1 ☔ View full report in Codecov by Sentry. |
owaiskazi19
approved these changes
May 1, 2024
dbwiddis
approved these changes
May 1, 2024
dbwiddis
reviewed
May 1, 2024
src/main/java/org/opensearch/flowframework/workflow/RegisterModelGroupStep.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Amit Galitzky <[email protected]>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
May 1, 2024
* adding context.restore when missed and fixing model group parsing Signed-off-by: Amit Galitzky <[email protected]> * adding change log, fix casting Signed-off-by: Amit Galitzky <[email protected]> * changed to contains key Signed-off-by: Amit Galitzky <[email protected]> --------- Signed-off-by: Amit Galitzky <[email protected]> (cherry picked from commit 28ea3dd) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
May 1, 2024
* adding context.restore when missed and fixing model group parsing Signed-off-by: Amit Galitzky <[email protected]> * adding change log, fix casting Signed-off-by: Amit Galitzky <[email protected]> * changed to contains key Signed-off-by: Amit Galitzky <[email protected]> --------- Signed-off-by: Amit Galitzky <[email protected]> (cherry picked from commit 28ea3dd) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
amitgalitz
pushed a commit
that referenced
this pull request
May 1, 2024
Fixing model group parsing and restoring context (#695) * adding context.restore when missed and fixing model group parsing * adding change log, fix casting * changed to contains key --------- (cherry picked from commit 28ea3dd) Signed-off-by: Amit Galitzky <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
amitgalitz
pushed a commit
that referenced
this pull request
May 1, 2024
Fixing model group parsing and restoring context (#695) * adding context.restore when missed and fixing model group parsing * adding change log, fix casting * changed to contains key --------- (cherry picked from commit 28ea3dd) Signed-off-by: Amit Galitzky <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding restore.context() in multiple place it isn't restored after stashing.
Fixing model group access_mode parsing, this was always failing but never tested with private on security enabled domain
Issues Resolved
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.