Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Throw the correct error message in status API for WorkflowSteps #683

Merged
merged 1 commit into from
Apr 26, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 56e4a78 from #676.

* Hides user and credential field from search response (#680)

* Hide user and credential field from search response

Signed-off-by: Owais Kazi <[email protected]>

* Hid the user field for Get API as well

Signed-off-by: Owais Kazi <[email protected]>

* Addressed PR Comments

Signed-off-by: Owais Kazi <[email protected]>

* Added user permission and new tests

Signed-off-by: Owais Kazi <[email protected]>

---------

Signed-off-by: Owais Kazi <[email protected]>

* Addressed PR Comments

Signed-off-by: Owais Kazi <[email protected]>

* Fixed failing test

Signed-off-by: Owais Kazi <[email protected]>

---------

Signed-off-by: Owais Kazi <[email protected]>
(cherry picked from commit 56e4a78)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Copy link

codecov bot commented Apr 26, 2024

Codecov Report

Attention: Patch coverage is 57.57576% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 72.64%. Comparing base (a80737f) to head (a13ed1f).

Files Patch % Lines
...flowframework/exception/WorkflowStepException.java 50.00% 0 Missing and 2 partials ⚠️
...rk/transport/ProvisionWorkflowTransportAction.java 0.00% 1 Missing ⚠️
...framework/workflow/AbstractCreatePipelineStep.java 50.00% 0 Missing and 1 partial ⚠️
...ework/workflow/AbstractRegisterLocalModelStep.java 75.00% 0 Missing and 1 partial ⚠️
...ch/flowframework/workflow/CreateConnectorStep.java 50.00% 0 Missing and 1 partial ⚠️
...search/flowframework/workflow/CreateIndexStep.java 75.00% 0 Missing and 1 partial ⚠️
...search/flowframework/workflow/DeleteAgentStep.java 50.00% 0 Missing and 1 partial ⚠️
...ch/flowframework/workflow/DeleteConnectorStep.java 50.00% 0 Missing and 1 partial ⚠️
...search/flowframework/workflow/DeleteModelStep.java 50.00% 0 Missing and 1 partial ⚠️
...search/flowframework/workflow/DeployModelStep.java 50.00% 0 Missing and 1 partial ⚠️
... and 3 more
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x     #683      +/-   ##
============================================
- Coverage     72.88%   72.64%   -0.25%     
- Complexity      694      697       +3     
============================================
  Files            82       82              
  Lines          3589     3605      +16     
  Branches        296      309      +13     
============================================
+ Hits           2616     2619       +3     
  Misses          841      841              
- Partials        132      145      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dbwiddis dbwiddis merged commit dd2d11b into 2.x Apr 26, 2024
33 of 34 checks passed
@dbwiddis dbwiddis deleted the backport/backport-676-to-2.x branch April 26, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants