-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding create search pipeline step #569
Adding create search pipeline step #569
Conversation
Signed-off-by: Amit Galitzky <[email protected]>
7aaf859
to
9f19dd0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with some nits.
src/main/java/org/opensearch/flowframework/common/WorkflowResources.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/flowframework/workflow/WorkflowStepFactory.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM pending fixes for the nits @dbwiddis mentioned
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a minor comment
src/test/java/org/opensearch/flowframework/workflow/CreateSearchPipelineStepTests.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Amit Galitzky <[email protected]>
4d06699
to
d3a3708
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #569 +/- ##
============================================
+ Coverage 72.24% 72.48% +0.24%
- Complexity 653 657 +4
============================================
Files 78 80 +2
Lines 3397 3416 +19
Branches 269 270 +1
============================================
+ Hits 2454 2476 +22
+ Misses 825 822 -3
Partials 118 118 ☔ View full report in Codecov by Sentry. |
This change would also require an update to the documentation because we are introducing new param |
Good call out, and new steps |
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/flow-framework/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/flow-framework/backport-2.x
# Create a new branch
git switch --create backport/backport-569-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 bc2306b451e85f91a62952f16fcf23c2e9a8733c
# Push it to GitHub
git push --set-upstream origin backport/backport-569-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/flow-framework/backport-2.x Then, create a pull request where the |
* adding create search pipeline step Signed-off-by: Amit Galitzky <[email protected]> * addresing nit changes Signed-off-by: Amit Galitzky <[email protected]> --------- Signed-off-by: Amit Galitzky <[email protected]>
Description
Added create search pipeline step by creating an abstract create pipeline step since both have same required in puts and almost exact same logic:
example:
Issues Resolved
resolves #545
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.