Fix max workflows setting test #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Widdis <[email protected]>
dbwiddis
requested review from
owaiskazi19,
joshpalis,
ohltyler,
amitgalitz and
jackiehanyang
as code owners
joshpalis
approved these changes
Dec 11, 2023
amitgalitz
approved these changes
Dec 12, 2023
|
btw if we merge this to main, it will mean it will be slightly out of order when we merge things back from feature branch. We might have already broken the order in other places though |
Ordering doesn't matter much, it's whether there are conflicting changes to the same files. One file hasn't been touched on the feature branch, one has changes only from backporting something from main, and the last has only overlapping identical changes in imports (which won't conflict) and changed lines of code that won't conflict. |
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Dec 13, 2023
Signed-off-by: Daniel Widdis <[email protected]> (cherry picked from commit 551e768) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Dec 13, 2023
Signed-off-by: Daniel Widdis <[email protected]> (cherry picked from commit 551e768) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dbwiddis
pushed a commit
that referenced
this pull request
Dec 13, 2023
Fix max workflows setting test (#268) (cherry picked from commit 551e768) Signed-off-by: Daniel Widdis <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dbwiddis
pushed a commit
that referenced
this pull request
Dec 13, 2023
Fix max workflows setting test (#268) (cherry picked from commit 551e768) Signed-off-by: Daniel Widdis <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes a typo where the setting wasn't actually being checked and was using the default.
Also fixed some javadoc warnings
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.