-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature/agent_framework] Registers a single agent with multiple tools #198
[Feature/agent_framework] Registers a single agent with multiple tools #198
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First pass
src/main/java/org/opensearch/flowframework/workflow/RegisterAgentStep.java
Show resolved
Hide resolved
src/main/java/org/opensearch/flowframework/model/WorkflowNode.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/flowframework/transport/CreateWorkflowTransportAction.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/flowframework/workflow/ToolStep.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/flowframework/workflow/GetTask.java
Outdated
Show resolved
Hide resolved
18e331e
to
952e825
Compare
461a618
to
4947b8f
Compare
@owaiskazi19 Regarding the
|
@joshpalis That's how it's here. These params are of the agent and params under llm are model related params. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good to me, just a question
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, as long as other comments are resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks Owais for addressing my comments
Signed-off-by: Owais Kazi <[email protected]>
Signed-off-by: Owais Kazi <[email protected]>
Signed-off-by: Owais Kazi <[email protected]>
Signed-off-by: Owais Kazi <[email protected]>
Signed-off-by: Owais Kazi <[email protected]>
Signed-off-by: Owais Kazi <[email protected]>
Signed-off-by: Owais Kazi <[email protected]>
Signed-off-by: Owais Kazi <[email protected]>
Signed-off-by: Owais Kazi <[email protected]>
Signed-off-by: Owais Kazi <[email protected]>
Signed-off-by: Owais Kazi <[email protected]>
Signed-off-by: Owais Kazi <[email protected]>
Signed-off-by: Owais Kazi <[email protected]>
Signed-off-by: Owais Kazi <[email protected]>
Signed-off-by: Owais Kazi <[email protected]>
Signed-off-by: Owais Kazi <[email protected]>
Signed-off-by: Owais Kazi <[email protected]>
Signed-off-by: Owais Kazi <[email protected]>
Signed-off-by: Owais Kazi <[email protected]>
ed27c59
to
bf93596
Compare
Signed-off-by: Owais Kazi <[email protected]>
bf93596
to
e4fb376
Compare
10d0840
into
opensearch-project:feature/agent_framework
opensearch-project#198) * Initial register agent workflow step Signed-off-by: Owais Kazi <[email protected]> * Added tools step Signed-off-by: Owais Kazi <[email protected]> * Fixed ClassCastException Signed-off-by: Owais Kazi <[email protected]> * Handled exception for Instant Signed-off-by: Owais Kazi <[email protected]> * Added type Instant for WorklowNode Parser Signed-off-by: Owais Kazi <[email protected]> * Removed created and last updated time Signed-off-by: Owais Kazi <[email protected]> * Addressed parsing error Signed-off-by: Owais Kazi <[email protected]> * Handled parsing of Long values for Instant Signed-off-by: Owais Kazi <[email protected]> * Handled nested object for llm key Signed-off-by: Owais Kazi <[email protected]> * Handled parsing error Signed-off-by: Owais Kazi <[email protected]> * Another attempt to fix parsing error for llm Signed-off-by: Owais Kazi <[email protected]> * Another attemp to fix XContent Signed-off-by: Owais Kazi <[email protected]> * Fixed Parsing error Signed-off-by: Owais Kazi <[email protected]> * Added tests for toolstep and javadocs Signed-off-by: Owais Kazi <[email protected]> * Undo CI changes Signed-off-by: Owais Kazi <[email protected]> * Addressing PR comments Signed-off-by: Owais Kazi <[email protected]> * Addressing PR comments Signed-off-by: Owais Kazi <[email protected]> * Handled interface changes Signed-off-by: Owais Kazi <[email protected]> * Addressed conflicts Signed-off-by: Owais Kazi <[email protected]> * Added TODO Signed-off-by: Owais Kazi <[email protected]> --------- Signed-off-by: Owais Kazi <[email protected]>
#198) * Initial register agent workflow step Signed-off-by: Owais Kazi <[email protected]> * Added tools step Signed-off-by: Owais Kazi <[email protected]> * Fixed ClassCastException Signed-off-by: Owais Kazi <[email protected]> * Handled exception for Instant Signed-off-by: Owais Kazi <[email protected]> * Added type Instant for WorklowNode Parser Signed-off-by: Owais Kazi <[email protected]> * Removed created and last updated time Signed-off-by: Owais Kazi <[email protected]> * Addressed parsing error Signed-off-by: Owais Kazi <[email protected]> * Handled parsing of Long values for Instant Signed-off-by: Owais Kazi <[email protected]> * Handled nested object for llm key Signed-off-by: Owais Kazi <[email protected]> * Handled parsing error Signed-off-by: Owais Kazi <[email protected]> * Another attempt to fix parsing error for llm Signed-off-by: Owais Kazi <[email protected]> * Another attemp to fix XContent Signed-off-by: Owais Kazi <[email protected]> * Fixed Parsing error Signed-off-by: Owais Kazi <[email protected]> * Added tests for toolstep and javadocs Signed-off-by: Owais Kazi <[email protected]> * Undo CI changes Signed-off-by: Owais Kazi <[email protected]> * Addressing PR comments Signed-off-by: Owais Kazi <[email protected]> * Addressing PR comments Signed-off-by: Owais Kazi <[email protected]> * Handled interface changes Signed-off-by: Owais Kazi <[email protected]> * Addressed conflicts Signed-off-by: Owais Kazi <[email protected]> * Added TODO Signed-off-by: Owais Kazi <[email protected]> --------- Signed-off-by: Owais Kazi <[email protected]>
opensearch-project#198) * Initial register agent workflow step Signed-off-by: Owais Kazi <[email protected]> * Added tools step Signed-off-by: Owais Kazi <[email protected]> * Fixed ClassCastException Signed-off-by: Owais Kazi <[email protected]> * Handled exception for Instant Signed-off-by: Owais Kazi <[email protected]> * Added type Instant for WorklowNode Parser Signed-off-by: Owais Kazi <[email protected]> * Removed created and last updated time Signed-off-by: Owais Kazi <[email protected]> * Addressed parsing error Signed-off-by: Owais Kazi <[email protected]> * Handled parsing of Long values for Instant Signed-off-by: Owais Kazi <[email protected]> * Handled nested object for llm key Signed-off-by: Owais Kazi <[email protected]> * Handled parsing error Signed-off-by: Owais Kazi <[email protected]> * Another attempt to fix parsing error for llm Signed-off-by: Owais Kazi <[email protected]> * Another attemp to fix XContent Signed-off-by: Owais Kazi <[email protected]> * Fixed Parsing error Signed-off-by: Owais Kazi <[email protected]> * Added tests for toolstep and javadocs Signed-off-by: Owais Kazi <[email protected]> * Undo CI changes Signed-off-by: Owais Kazi <[email protected]> * Addressing PR comments Signed-off-by: Owais Kazi <[email protected]> * Addressing PR comments Signed-off-by: Owais Kazi <[email protected]> * Handled interface changes Signed-off-by: Owais Kazi <[email protected]> * Addressed conflicts Signed-off-by: Owais Kazi <[email protected]> * Added TODO Signed-off-by: Owais Kazi <[email protected]> --------- Signed-off-by: Owais Kazi <[email protected]>
#198) * Initial register agent workflow step Signed-off-by: Owais Kazi <[email protected]> * Added tools step Signed-off-by: Owais Kazi <[email protected]> * Fixed ClassCastException Signed-off-by: Owais Kazi <[email protected]> * Handled exception for Instant Signed-off-by: Owais Kazi <[email protected]> * Added type Instant for WorklowNode Parser Signed-off-by: Owais Kazi <[email protected]> * Removed created and last updated time Signed-off-by: Owais Kazi <[email protected]> * Addressed parsing error Signed-off-by: Owais Kazi <[email protected]> * Handled parsing of Long values for Instant Signed-off-by: Owais Kazi <[email protected]> * Handled nested object for llm key Signed-off-by: Owais Kazi <[email protected]> * Handled parsing error Signed-off-by: Owais Kazi <[email protected]> * Another attempt to fix parsing error for llm Signed-off-by: Owais Kazi <[email protected]> * Another attemp to fix XContent Signed-off-by: Owais Kazi <[email protected]> * Fixed Parsing error Signed-off-by: Owais Kazi <[email protected]> * Added tests for toolstep and javadocs Signed-off-by: Owais Kazi <[email protected]> * Undo CI changes Signed-off-by: Owais Kazi <[email protected]> * Addressing PR comments Signed-off-by: Owais Kazi <[email protected]> * Addressing PR comments Signed-off-by: Owais Kazi <[email protected]> * Handled interface changes Signed-off-by: Owais Kazi <[email protected]> * Addressed conflicts Signed-off-by: Owais Kazi <[email protected]> * Added TODO Signed-off-by: Owais Kazi <[email protected]> --------- Signed-off-by: Owais Kazi <[email protected]>
opensearch-project#198) * Initial register agent workflow step Signed-off-by: Owais Kazi <[email protected]> * Added tools step Signed-off-by: Owais Kazi <[email protected]> * Fixed ClassCastException Signed-off-by: Owais Kazi <[email protected]> * Handled exception for Instant Signed-off-by: Owais Kazi <[email protected]> * Added type Instant for WorklowNode Parser Signed-off-by: Owais Kazi <[email protected]> * Removed created and last updated time Signed-off-by: Owais Kazi <[email protected]> * Addressed parsing error Signed-off-by: Owais Kazi <[email protected]> * Handled parsing of Long values for Instant Signed-off-by: Owais Kazi <[email protected]> * Handled nested object for llm key Signed-off-by: Owais Kazi <[email protected]> * Handled parsing error Signed-off-by: Owais Kazi <[email protected]> * Another attempt to fix parsing error for llm Signed-off-by: Owais Kazi <[email protected]> * Another attemp to fix XContent Signed-off-by: Owais Kazi <[email protected]> * Fixed Parsing error Signed-off-by: Owais Kazi <[email protected]> * Added tests for toolstep and javadocs Signed-off-by: Owais Kazi <[email protected]> * Undo CI changes Signed-off-by: Owais Kazi <[email protected]> * Addressing PR comments Signed-off-by: Owais Kazi <[email protected]> * Addressing PR comments Signed-off-by: Owais Kazi <[email protected]> * Handled interface changes Signed-off-by: Owais Kazi <[email protected]> * Addressed conflicts Signed-off-by: Owais Kazi <[email protected]> * Added TODO Signed-off-by: Owais Kazi <[email protected]> --------- Signed-off-by: Owais Kazi <[email protected]>
opensearch-project#198) * Initial register agent workflow step Signed-off-by: Owais Kazi <[email protected]> * Added tools step Signed-off-by: Owais Kazi <[email protected]> * Fixed ClassCastException Signed-off-by: Owais Kazi <[email protected]> * Handled exception for Instant Signed-off-by: Owais Kazi <[email protected]> * Added type Instant for WorklowNode Parser Signed-off-by: Owais Kazi <[email protected]> * Removed created and last updated time Signed-off-by: Owais Kazi <[email protected]> * Addressed parsing error Signed-off-by: Owais Kazi <[email protected]> * Handled parsing of Long values for Instant Signed-off-by: Owais Kazi <[email protected]> * Handled nested object for llm key Signed-off-by: Owais Kazi <[email protected]> * Handled parsing error Signed-off-by: Owais Kazi <[email protected]> * Another attempt to fix parsing error for llm Signed-off-by: Owais Kazi <[email protected]> * Another attemp to fix XContent Signed-off-by: Owais Kazi <[email protected]> * Fixed Parsing error Signed-off-by: Owais Kazi <[email protected]> * Added tests for toolstep and javadocs Signed-off-by: Owais Kazi <[email protected]> * Undo CI changes Signed-off-by: Owais Kazi <[email protected]> * Addressing PR comments Signed-off-by: Owais Kazi <[email protected]> * Addressing PR comments Signed-off-by: Owais Kazi <[email protected]> * Handled interface changes Signed-off-by: Owais Kazi <[email protected]> * Addressed conflicts Signed-off-by: Owais Kazi <[email protected]> * Added TODO Signed-off-by: Owais Kazi <[email protected]> --------- Signed-off-by: Owais Kazi <[email protected]>
Description
This PR has couple of new functionalities:
llm
fieldTODO:
parameter
field of ToolStep.<List<WorkflowData>>
param inexecute
method and that nodeID can be used to store the response with the agent_id.modelId
in response, need to attach the nodeId to make that modelId unique in the map of WorkflowData.Request:
Response from the Logs:
Issues Resolved
Fixes #196
Part of #194
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.