-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check if Index exists before max workflow check #178
Merged
owaiskazi19
merged 3 commits into
opensearch-project:main
from
amitgalitz:resource-changes
Nov 20, 2023
Merged
Check if Index exists before max workflow check #178
owaiskazi19
merged 3 commits into
opensearch-project:main
from
amitgalitz:resource-changes
Nov 20, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Amit Galitzky <[email protected]>
amitgalitz
requested review from
dbwiddis,
owaiskazi19,
joshpalis,
ohltyler and
jackiehanyang
as code owners
November 20, 2023 19:39
owaiskazi19
reviewed
Nov 20, 2023
src/main/java/org/opensearch/flowframework/transport/CreateWorkflowTransportAction.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Amit Galitzky <[email protected]>
joshpalis
approved these changes
Nov 20, 2023
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #178 +/- ##
============================================
+ Coverage 72.09% 72.12% +0.02%
- Complexity 406 407 +1
============================================
Files 53 53
Lines 1946 1948 +2
Branches 164 164
============================================
+ Hits 1403 1405 +2
+ Misses 472 471 -1
- Partials 71 72 +1 ☔ View full report in Codecov by Sentry. |
owaiskazi19
reviewed
Nov 20, 2023
src/main/java/org/opensearch/flowframework/transport/CreateWorkflowTransportAction.java
Outdated
Show resolved
Hide resolved
owaiskazi19
reviewed
Nov 20, 2023
src/main/java/org/opensearch/flowframework/transport/CreateWorkflowTransportAction.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Amit Galitzky <[email protected]>
amitgalitz
force-pushed
the
resource-changes
branch
from
November 20, 2023 21:29
3d8eb8e
to
4ecbef3
Compare
owaiskazi19
approved these changes
Nov 20, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Nov 20, 2023
* adding check to init GC index if absent before max workflow check Signed-off-by: Amit Galitzky <[email protected]> * moved check if index exists earlier Signed-off-by: Amit Galitzky <[email protected]> * added test and switched to if/else Signed-off-by: Amit Galitzky <[email protected]> --------- Signed-off-by: Amit Galitzky <[email protected]> (cherry picked from commit d3ab0ef) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
joshpalis
pushed a commit
that referenced
this pull request
Nov 20, 2023
Check if Index exists before max workflow check (#178) * adding check to init GC index if absent before max workflow check * moved check if index exists earlier * added test and switched to if/else --------- (cherry picked from commit d3ab0ef) Signed-off-by: Amit Galitzky <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Nov 27, 2023
* adding check to init GC index if absent before max workflow check Signed-off-by: Amit Galitzky <[email protected]> * moved check if index exists earlier Signed-off-by: Amit Galitzky <[email protected]> * added test and switched to if/else Signed-off-by: Amit Galitzky <[email protected]> --------- Signed-off-by: Amit Galitzky <[email protected]> (cherry picked from commit d3ab0ef) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
joshpalis
pushed a commit
that referenced
this pull request
Nov 27, 2023
…orkflow check (#201) Check if Index exists before max workflow check (#178) * adding check to init GC index if absent before max workflow check * moved check if index exists earlier * added test and switched to if/else --------- (cherry picked from commit d3ab0ef) Signed-off-by: Amit Galitzky <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checking if GC index exists before checking how many existing current workflows we have, and initializing if it doesn't
All I did was wrap it with following code, github change looks weird
Issues Resolved
resolves #174
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.