Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Adding a get status API #172

Merged
merged 1 commit into from
Nov 15, 2023
Merged

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport e3bbfcb from #148.

* adding workflow state and create connector resources created

Signed-off-by: Amit Galitzky <[email protected]>

* add plugin enabled setting check for get status api

Signed-off-by: Amit Galitzky <[email protected]>

* addressing comments

Signed-off-by: Amit Galitzky <[email protected]>

* addressing additional conflicts

Signed-off-by: Amit Galitzky <[email protected]>

* addressed comments and added more tests

Signed-off-by: Amit Galitzky <[email protected]>

* removed additional listener in provision action

Signed-off-by: Amit Galitzky <[email protected]>

* changed resourcescreated to resourceCreated and other minor comment changes

Signed-off-by: Amit Galitzky <[email protected]>

---------

Signed-off-by: Amit Galitzky <[email protected]>
(cherry picked from commit e3bbfcb)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Copy link

codecov bot commented Nov 15, 2023

Codecov Report

Attention: 119 lines in your changes are missing coverage. Please review.

Comparison is base (4813fc0) 70.08% compared to head (848e1bd) 72.09%.
Report is 2 commits behind head on 2.x.

Files Patch % Lines
...ramework/transport/GetWorkflowTransportAction.java 38.70% 19 Missing ⚠️
...framework/indices/FlowFrameworkIndicesHandler.java 0.00% 17 Missing ⚠️
.../opensearch/flowframework/model/WorkflowState.java 58.97% 13 Missing and 3 partials ⚠️
...rk/transport/ProvisionWorkflowTransportAction.java 23.80% 16 Missing ⚠️
...arch/flowframework/rest/RestGetWorkflowAction.java 53.12% 14 Missing and 1 partial ⚠️
...a/org/opensearch/flowframework/model/Template.java 77.04% 13 Missing and 1 partial ⚠️
...pensearch/flowframework/model/ResourceCreated.java 73.52% 8 Missing and 1 partial ⚠️
...ch/flowframework/workflow/CreateConnectorStep.java 65.21% 8 Missing ⚠️
...h/flowframework/transport/GetWorkflowResponse.java 87.50% 1 Missing and 1 partial ⚠️
...ework/transport/CreateWorkflowTransportAction.java 50.00% 1 Missing ⚠️
... and 2 more
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x     #172      +/-   ##
============================================
+ Coverage     70.08%   72.09%   +2.01%     
- Complexity      366      406      +40     
============================================
  Files            47       53       +6     
  Lines          1688     1946     +258     
  Branches        154      164      +10     
============================================
+ Hits           1183     1403     +220     
- Misses          451      472      +21     
- Partials         54       71      +17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joshpalis joshpalis merged commit d9ce7c5 into 2.x Nov 15, 2023
14 of 15 checks passed
@github-actions github-actions bot deleted the backport/backport-148-to-2.x branch November 15, 2023 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant