Publish feature branch of ml-commons #143
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Owais Kazi <[email protected]>
Signed-off-by: Owais Kazi <[email protected]>
Signed-off-by: Owais Kazi <[email protected]>
dbwiddis
reviewed
Nov 2, 2023
.github/workflows/CI.yml
Outdated
| - uses: actions/checkout@v4 | ||
| with: | ||
| repository: opensearch-project/ml-commons | ||
| ref: agent_framework_dev |
There was a problem hiding this comment.
Suggested change
| ref: agent_framework_dev | |
| ref: agent_framework |
owaiskazi19
force-pushed
the
setup-ci-ml
branch
3 times, most recently
from
d8591c6 to
6374e9a
Compare
Signed-off-by: Owais Kazi <[email protected]>
owaiskazi19
force-pushed
the
setup-ci-ml
branch
from
6374e9a to
70baff9
Compare
|
Looks like the gradlew check is still fetching the ml-commons dependency from maven. Otherwise it would have failed because the APIs like regsiter, deploy etc are not present in the feature branch. |
|
Closing this as the CI changes are handled in #169. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Publish
agent_framework_devbranch of ml-commons as development is going on the feature branch.Keeping it draft for testing and waiting for all the PRs to be merged to feature branch.
Issues Resolved
Fixes #138
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.