Adding dry run test

Signed-off-by: Joshua Palis <[email protected]>
opensearch-project · Nov 2, 2023 · a72904a · a72904a
1 parent 3021b3d
commit a72904a
Showing 1 changed file with 66 additions and 2 deletions.
diff --git a/src/test/java/org/opensearch/flowframework/transport/CreateWorkflowTransportActionTests.java b/src/test/java/org/opensearch/flowframework/transport/CreateWorkflowTransportActionTests.java
@@ -23,6 +23,7 @@
 import org.opensearch.flowframework.model.WorkflowNode;
 import org.opensearch.flowframework.util.ParseUtils;
 import org.opensearch.flowframework.workflow.WorkflowProcessSorter;
+import org.opensearch.flowframework.workflow.WorkflowStepFactory;
 import org.opensearch.tasks.Task;
 import org.opensearch.test.OpenSearchTestCase;
 import org.opensearch.threadpool.ThreadPool;
@@ -44,6 +45,7 @@ public class CreateWorkflowTransportActionTests extends OpenSearchTestCase {
 
     private CreateWorkflowTransportAction createWorkflowTransportAction;
     private FlowFrameworkIndicesHandler flowFrameworkIndicesHandler;
+    private WorkflowProcessSorter workflowProcessSorter;
     private Template template;
     private Client client = mock(Client.class);
     private ThreadPool threadPool;
@@ -53,15 +55,16 @@ public class CreateWorkflowTransportActionTests extends OpenSearchTestCase {
     @Override
     public void setUp() throws Exception {
         super.setUp();
+        threadPool = mock(ThreadPool.class);
         this.flowFrameworkIndicesHandler = mock(FlowFrameworkIndicesHandler.class);
+        this.workflowProcessSorter = new WorkflowProcessSorter(mock(WorkflowStepFactory.class), threadPool);
         this.createWorkflowTransportAction = new CreateWorkflowTransportAction(
             mock(TransportService.class),
             mock(ActionFilters.class),
-            mock(WorkflowProcessSorter.class),
+            workflowProcessSorter,
             flowFrameworkIndicesHandler,
             client
         );
-        threadPool = mock(ThreadPool.class);
         // client = mock(Client.class);
         ThreadContext threadContext = new ThreadContext(Settings.EMPTY);
         // threadContext = mock(ThreadContext.class);
@@ -90,6 +93,67 @@ public void setUp() throws Exception {
         );
     }
 
+    public void testFailedDryRunValidation() {
+
+        WorkflowNode createConnector = new WorkflowNode(
+            "workflow_step_1",
+            "create_connector",
+            Map.of(),
+            Map.ofEntries(
+                Map.entry("name", ""),
+                Map.entry("description", ""),
+                Map.entry("version", ""),
+                Map.entry("protocol", ""),
+                Map.entry("parameters", ""),
+                Map.entry("credential", ""),
+                Map.entry("actions", "")
+            )
+        );
+
+        WorkflowNode registerModel = new WorkflowNode(
+            "workflow_step_2",
+            "register_model",
+            Map.ofEntries(Map.entry("workflow_step_1", "connector_id")),
+            Map.ofEntries(Map.entry("name", "name"), Map.entry("function_name", "remote"), Map.entry("description", "description"))
+        );
+
+        WorkflowNode deployModel = new WorkflowNode(
+            "workflow_step_3",
+            "deploy_model",
+            Map.ofEntries(Map.entry("workflow_step_2", "model_id")),
+            Map.of()
+        );
+
+        WorkflowEdge edge1 = new WorkflowEdge(createConnector.id(), registerModel.id());
+        WorkflowEdge edge2 = new WorkflowEdge(registerModel.id(), deployModel.id());
+        WorkflowEdge cyclicalEdge = new WorkflowEdge(deployModel.id(), createConnector.id());
+
+        Workflow workflow = new Workflow(
+            Map.of(),
+            List.of(createConnector, registerModel, deployModel),
+            List.of(edge1, edge2, cyclicalEdge)
+        );
+
+        Template cyclicalTemplate = new Template(
+            "test",
+            "description",
+            "use case",
+            Version.fromString("1.0.0"),
+            List.of(Version.fromString("2.0.0"), Version.fromString("3.0.0")),
+            Map.of("workflow", workflow),
+            TestHelpers.randomUser()
+        );
+
+        @SuppressWarnings("unchecked")
+        ActionListener<WorkflowResponse> listener = mock(ActionListener.class);
+        WorkflowRequest createNewWorkflow = new WorkflowRequest(null, cyclicalTemplate, true);
+
+        createWorkflowTransportAction.doExecute(mock(Task.class), createNewWorkflow, listener);
+        ArgumentCaptor<Exception> exceptionCaptor = ArgumentCaptor.forClass(Exception.class);
+        verify(listener, times(1)).onFailure(exceptionCaptor.capture());
+        assertEquals("No start node detected: all nodes have a predecessor.", exceptionCaptor.getValue().getMessage());
+    }
+
     public void testFailedToCreateNewWorkflow() {
         @SuppressWarnings("unchecked")
         ActionListener<WorkflowResponse> listener = mock(ActionListener.class);