Fix example using custom_attr_whitelist and custom_attr_maxval_len in… #981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… ldap documentation Signed-off-by: Craig Perkins <[email protected]>
Naarcha-AWS
approved these changes
Aug 24, 2022
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 25, 2022
… ldap documentation (#981) Signed-off-by: Craig Perkins <[email protected]> Signed-off-by: Craig Perkins <[email protected]> (cherry picked from commit c48cf8c)
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-981-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 c48cf8c600a9a714b718842836ce47c9b9ac33dd
# Push it to GitHub
git push --set-upstream origin backport/backport-981-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.xThen, create a pull request where the |
|
@cwillum @Naarcha-AWS Looks like the backport to 2.x did not work automatically. Should I go ahead and run the manual steps? |
|
@cwperks I think we need to break these out into separate backport 2.0, 2.1, and 2.2 PRs. The "2.x" label was an attempt to consolidate the backport operation. We can probably revert and generate a new PR to do this. Will check in with @Naarcha-AWS . |
Naarcha-AWS
added
backport 2.0
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 26, 2022
… ldap documentation (#981) Signed-off-by: Craig Perkins <[email protected]> Signed-off-by: Craig Perkins <[email protected]> (cherry picked from commit c48cf8c)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 26, 2022
… ldap documentation (#981) Signed-off-by: Craig Perkins <[email protected]> Signed-off-by: Craig Perkins <[email protected]> (cherry picked from commit c48cf8c)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 26, 2022
… ldap documentation (#981) Signed-off-by: Craig Perkins <[email protected]> Signed-off-by: Craig Perkins <[email protected]> (cherry picked from commit c48cf8c)
Naarcha-AWS
pushed a commit
that referenced
this pull request
Aug 26, 2022
… ldap documentation (#981) (#1012) Signed-off-by: Craig Perkins <[email protected]> Signed-off-by: Craig Perkins <[email protected]> (cherry picked from commit c48cf8c) Co-authored-by: Craig Perkins <[email protected]>
Naarcha-AWS
pushed a commit
that referenced
this pull request
Aug 26, 2022
… ldap documentation (#981) (#1011) Signed-off-by: Craig Perkins <[email protected]> Signed-off-by: Craig Perkins <[email protected]> (cherry picked from commit c48cf8c) Co-authored-by: Craig Perkins <[email protected]>
Naarcha-AWS
pushed a commit
that referenced
this pull request
Aug 26, 2022
… ldap documentation (#981) (#1010) Signed-off-by: Craig Perkins <[email protected]> Signed-off-by: Craig Perkins <[email protected]> (cherry picked from commit c48cf8c) Co-authored-by: Craig Perkins <[email protected]>
|
@cwperks: I went ahead and generated the backport PR for 2.0 for you. I was experimenting with the 2.x label. Sorry for the confusion! |
Naarcha-AWS
pushed a commit
that referenced
this pull request
Aug 29, 2022
… ldap documentation (#981) (#1005) Signed-off-by: Craig Perkins <[email protected]> Signed-off-by: Craig Perkins <[email protected]> (cherry picked from commit c48cf8c) Co-authored-by: Craig Perkins <[email protected]>
|
Thank you @Naarcha-AWS ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… ldap documentation
Signed-off-by: Craig Perkins [email protected]
Description
The section on (Advanced) Control LDAP user attributes contains a mistake in the example of how to configure the attributes
custom_attr_whitelistandcustom_attr_maxval_len, this PR updates the documentation to ensure the example is in the correct area of the security configuration.Issues Resolved
Related Issue issue from the
securityrepo: opensearch-project/security#2032By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.