Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update docs on how to connect with Amazon OpenSearch Service via HTTP. #8987

Merged
merged 2 commits into from
Dec 30, 2024
Merged

Update docs on how to connect with Amazon OpenSearch Service via HTTP. #8987

merged 2 commits into from
Dec 30, 2024

Conversation

Martins6
Copy link
Contributor

@Martins6 Martins6 commented Dec 27, 2024 •
edited
Loading

Description

This commit enhances the documentation on how to connect with Amazon OpenSearch service via HTTP.

Issues Resolved

#8988

Version

All.

Frontend features

No frontend feature.

Checklist

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@Martins6
Update python-low-level.md to detail how to connect with Amazon OpenS…
0d27257 
…earch service via HTTP

This commit enhances the documentation on how to connect with Amazon OpenSearch service via HTTP.

Signed-off-by: Adriel Martins <[email protected]>
@github-actions GitHub Actions
Copy link

Thank you for submitting your PR. The PR states are In progress (or Draft) -> Tech review -> Doc review -> Editorial review -> Merged.

Before you submit your PR for doc review, make sure the content is technically accurate. If you need help finding a tech reviewer, tag a maintainer.

When you're ready for doc review, tag the assignee of this PR. The doc reviewer may push edits to the PR directly or leave comments and editorial suggestions for you to address (let us know in a comment if you have a preference). The doc reviewer will arrange for an editorial review.

@Martins6
Copy link
Contributor Author

@kolchfa-aws, I'm ready for doc review! Let me know, if this is needed or not. Thank you!

kolchfa-aws
kolchfa-aws reviewed Dec 30, 2024
View reviewed changes
Copy link
Collaborator

@kolchfa-aws kolchfa-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @Martins6! A couple of suggestions.

_clients/python-low-level.md Outdated Show resolved Hide resolved
_clients/python-low-level.md Outdated Show resolved Hide resolved
@Martins6 @kolchfa-aws
Apply suggestions from code review
3ec42f9 
Co-authored-by: kolchfa-aws <[email protected]>
Signed-off-by: Adriel Martins <[email protected]>
@Martins6
Copy link
Contributor Author

@kolchfa-aws, I'm ready for doc review! Let me know, if this is needed or not. Thank you!

Thank you for the suggestions, @kolchfa-aws ! Already merged them. :)

@Martins6 Martins6 requested a review from kolchfa-aws December 30, 2024 13:40
kolchfa-aws
kolchfa-aws approved these changes Dec 30, 2024
View reviewed changes
Copy link
Collaborator

@kolchfa-aws kolchfa-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kolchfa-aws kolchfa-aws added the backport 2.18 PR: Backport label for 2.18 label Dec 30, 2024
@kolchfa-aws kolchfa-aws merged commit ca2e7f4 into opensearch-project:main Dec 30, 2024
6 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Dec 30, 2024
@github-actions @kolchfa-aws
Update docs on how to connect with Amazon OpenSearch Service via HTTP. (
549f154 
#8987)

* Update python-low-level.md to detail how to connect with Amazon OpenSearch service via HTTP

This commit enhances the documentation on how to connect with Amazon OpenSearch service via HTTP.

Signed-off-by: Adriel Martins <[email protected]>

* Apply suggestions from code review

Co-authored-by: kolchfa-aws <[email protected]>
Signed-off-by: Adriel Martins <[email protected]>

---------

Signed-off-by: Adriel Martins <[email protected]>
Co-authored-by: kolchfa-aws <[email protected]>
(cherry picked from commit ca2e7f4)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Dec 30, 2024
Merged
@Martins6 Martins6 deleted the patch-1 branch December 30, 2024 15:39
github-actions bot pushed a commit that referenced this pull request Dec 30, 2024
@opensearch-trigger-bot
Update docs on how to connect with Amazon OpenSearch Service via HTTP. (
6173762 
#8987) (#8992)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kolchfa-aws kolchfa-aws kolchfa-aws approved these changes

@Naarcha-AWS Naarcha-AWS Awaiting requested review from Naarcha-AWS Naarcha-AWS is a code owner

@AMoo-Miki AMoo-Miki Awaiting requested review from AMoo-Miki AMoo-Miki is a code owner

@natebower natebower Awaiting requested review from natebower natebower is a code owner

@dlvenable dlvenable Awaiting requested review from dlvenable dlvenable is a code owner

@epugh epugh Awaiting requested review from epugh epugh is a code owner

Assignees

@kolchfa-aws kolchfa-aws

Labels
backport 2.18 PR: Backport label for 2.18
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Martins6 @kolchfa-aws