Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation from opensearch_security_roles to opendistro_sec… #892

Merged

Conversation

cwperks
Copy link
Member

@cwperks cwperks commented Aug 15, 2022

…urity_roles

Signed-off-by: Craig Perkins [email protected]

Description

Users are reporting an error in the internal_users.yml documentation. This PR corrects the error in documentation.

Issues Resolved

Closes opensearch-project/security#1339

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Member

@peternied peternied left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should update this to fix the bug in our documentation

Copy link
Contributor

@cwillum cwillum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Understood. This looks good to me.

@Naarcha-AWS Naarcha-AWS added backport 2.2 PR: Backport label for 2.2 backport 2.1 PR: Backport label for 2.1 backport 2.0 PR: Backport label for v2.0.x labels Aug 24, 2022
@Naarcha-AWS Naarcha-AWS merged commit 906a81b into opensearch-project:main Aug 24, 2022
opensearch-trigger-bot bot pushed a commit that referenced this pull request Aug 24, 2022
…urity_roles (#892)

Signed-off-by: Craig Perkins <[email protected]>

Signed-off-by: Craig Perkins <[email protected]>
(cherry picked from commit 906a81b)
opensearch-trigger-bot bot pushed a commit that referenced this pull request Aug 24, 2022
…urity_roles (#892)

Signed-off-by: Craig Perkins <[email protected]>

Signed-off-by: Craig Perkins <[email protected]>
(cherry picked from commit 906a81b)
opensearch-trigger-bot bot pushed a commit that referenced this pull request Aug 24, 2022
…urity_roles (#892)

Signed-off-by: Craig Perkins <[email protected]>

Signed-off-by: Craig Perkins <[email protected]>
(cherry picked from commit 906a81b)
Naarcha-AWS pushed a commit that referenced this pull request Aug 24, 2022
…urity_roles (#892) (#976)

Signed-off-by: Craig Perkins <[email protected]>

Signed-off-by: Craig Perkins <[email protected]>
(cherry picked from commit 906a81b)

Co-authored-by: Craig Perkins <[email protected]>
Naarcha-AWS pushed a commit that referenced this pull request Aug 24, 2022
…urity_roles (#892) (#975)

Signed-off-by: Craig Perkins <[email protected]>

Signed-off-by: Craig Perkins <[email protected]>
(cherry picked from commit 906a81b)

Co-authored-by: Craig Perkins <[email protected]>
Naarcha-AWS pushed a commit that referenced this pull request Aug 24, 2022
…urity_roles (#892) (#974)

Signed-off-by: Craig Perkins <[email protected]>

Signed-off-by: Craig Perkins <[email protected]>
(cherry picked from commit 906a81b)

Co-authored-by: Craig Perkins <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.0 PR: Backport label for v2.0.x backport 2.1 PR: Backport label for 2.1 backport 2.2 PR: Backport label for 2.2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

internal_users.yml expects opendistro specific security label
4 participants