Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix numbering on Kubernetes page #8878

Merged
merged 2 commits into from
Dec 4, 2024
Merged

Fix numbering on Kubernetes page #8878

merged 2 commits into from
Dec 4, 2024

Conversation

Naarcha-AWS
Copy link
Collaborator

Checklist

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@Naarcha-AWS Naarcha-AWS self-assigned this Dec 4, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 4, 2024

Thank you for submitting your PR. The PR states are In progress (or Draft) -> Tech review -> Doc review -> Editorial review -> Merged.

Before you submit your PR for doc review, make sure the content is technically accurate. If you need help finding a tech reviewer, tag a maintainer.

When you're ready for doc review, tag the assignee of this PR. The doc reviewer may push edits to the PR directly or leave comments and editorial suggestions for you to address (let us know in a comment if you have a preference). The doc reviewer will arrange for an editorial review.

@Naarcha-AWS Naarcha-AWS added the backport 2.18 PR: Backport label for 2.18 label Dec 4, 2024
@kolchfa-aws
Copy link
Collaborator

@Naarcha-AWS I think this does not have any changes except for the added spaces. Could you delete the spaces and verify?

@Naarcha-AWS
Copy link
Collaborator Author

@kolchfa-aws: Adding the spaces fixes the numbering on the list. Instead of resetting, the numbering on the list continues from line 64.

@Naarcha-AWS Naarcha-AWS changed the title Fix number in Kubernetes page Fix numbering on Kubernetes page Dec 4, 2024
@Naarcha-AWS Naarcha-AWS added the 4 - Doc review PR: Doc review in progress label Dec 4, 2024
@Naarcha-AWS Naarcha-AWS merged commit 2ec6da7 into main Dec 4, 2024
8 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Dec 4, 2024
@github-actions
Fix number in Kubernetes page (#8878)
230cd0c 
Signed-off-by: Naarcha-AWS <[email protected]>
(cherry picked from commit 2ec6da7)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Dec 4, 2024
Merged
Naarcha-AWS pushed a commit that referenced this pull request Dec 4, 2024
@opensearch-trigger-bot @github-actions
Fix number in Kubernetes page (#8878) (#8885)
6893587 
(cherry picked from commit 2ec6da7)

Signed-off-by: Naarcha-AWS <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@Naarcha-AWS Naarcha-AWS deleted the kubernetes-page branch December 19, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kolchfa-aws kolchfa-aws kolchfa-aws approved these changes

@vagimeli vagimeli Awaiting requested review from vagimeli

@AMoo-Miki AMoo-Miki Awaiting requested review from AMoo-Miki AMoo-Miki is a code owner

@natebower natebower Awaiting requested review from natebower natebower is a code owner

@dlvenable dlvenable Awaiting requested review from dlvenable dlvenable is a code owner

@epugh epugh Awaiting requested review from epugh epugh is a code owner

Assignees

@Naarcha-AWS Naarcha-AWS

Labels
4 - Doc review PR: Doc review in progress backport 2.18 PR: Backport label for 2.18
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Naarcha-AWS @kolchfa-aws