Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update workers parameter description with 1-10 range #8826

Merged
merged 5 commits into from
Dec 3, 2024

Conversation

christianfds
Copy link
Contributor

Description

Makes explicit the minimum and maximum range for the workers property on S3 usage as a source.

Issues Resolved

Closes #[insert issue number]
I have not found any issue related to this change

Version

All

Frontend features

If you're submitting documentation for an OpenSearch Dashboards feature, add a video that shows how a user will interact with the UI step by step. A voiceover is optional.

Checklist

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

Thank you for submitting your PR. The PR states are In progress (or Draft) -> Tech review -> Doc review -> Editorial review -> Merged.

Before you submit your PR for doc review, make sure the content is technically accurate. If you need help finding a tech reviewer, tag a maintainer.

When you're ready for doc review, tag the assignee of this PR. The doc reviewer may push edits to the PR directly or leave comments and editorial suggestions for you to address (let us know in a comment if you have a preference). The doc reviewer will arrange for an editorial review.

Copy link
Collaborator

@kolchfa-aws kolchfa-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @christianfds! A small suggestion.

_data-prepper/pipelines/configuration/sources/s3.md Outdated Show resolved Hide resolved
@kolchfa-aws kolchfa-aws merged commit f181085 into opensearch-project:main Dec 3, 2024
5 checks passed
@kolchfa-aws kolchfa-aws added the backport 2.18 PR: Backport label for 2.18 label Dec 3, 2024
opensearch-trigger-bot bot pushed a commit that referenced this pull request Dec 3, 2024
* Update workers parameter description with 1-10 range

Signed-off-by: Christian Franchin <[email protected]>

* Update _data-prepper/pipelines/configuration/sources/s3.md

Co-authored-by: kolchfa-aws <[email protected]>
Signed-off-by: Christian Franchin <[email protected]>

---------

Signed-off-by: Christian Franchin <[email protected]>
Co-authored-by: kolchfa-aws <[email protected]>
(cherry picked from commit f181085)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.18 PR: Backport label for 2.18
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants