-
Notifications
You must be signed in to change notification settings - Fork 503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document the X-Opaque-Id
header
#8820
Conversation
Thank you for submitting your PR. The PR states are In progress (or Draft) -> Tech review -> Doc review -> Editorial review -> Merged. Before you submit your PR for doc review, make sure the content is technically accurate. If you need help finding a tech reviewer, tag a maintainer. When you're ready for doc review, tag the assignee of this PR. The doc reviewer may push edits to the PR directly or leave comments and editorial suggestions for you to address (let us know in a comment if you have a preference). The doc reviewer will arrange for an editorial review. |
ac889b5
to
1877fb0
Compare
A [bug][1] was recently identified related to this header that was partly exascerbated by a misuse of the field. We have some documentation related to the [Tasks][2] API for this field, but no general guidance on how to use it. [1]: opensearch-project/OpenSearch#16702 [2]: https://opensearch.org/docs/latest/api-reference/tasks/#attaching-headers-to-tasks Signed-off-by: Andrew Ross <[email protected]>
1f674ec
to
b8e95cb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @andrross! A couple of suggestions.
Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: Andrew Ross <[email protected]>
Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: Andrew Ross <[email protected]>
Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: Andrew Ross <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kolchfa-aws @andrross Please see my changes and let me know if you have any questions. Thanks!
Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Andrew Ross <[email protected]>
Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Andrew Ross <[email protected]>
* Document the `X-Opaque-Id` header A [bug][1] was recently identified related to this header that was partly exascerbated by a misuse of the field. We have some documentation related to the [Tasks][2] API for this field, but no general guidance on how to use it. [1]: opensearch-project/OpenSearch#16702 [2]: https://opensearch.org/docs/latest/api-reference/tasks/#attaching-headers-to-tasks Signed-off-by: Andrew Ross <[email protected]> * Update _api-reference/common-parameters.md Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: Andrew Ross <[email protected]> * Update _api-reference/common-parameters.md Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: Andrew Ross <[email protected]> * Update _api-reference/common-parameters.md Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: Andrew Ross <[email protected]> * Update _api-reference/common-parameters.md Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Andrew Ross <[email protected]> * Update _api-reference/common-parameters.md Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Andrew Ross <[email protected]> --------- Signed-off-by: Andrew Ross <[email protected]> Co-authored-by: kolchfa-aws <[email protected]> Co-authored-by: Nathan Bower <[email protected]> (cherry picked from commit 1cd69cd) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
A bug was recently identified related to this header that was partly exascerbated by a misuse of the field. We have some documentation related to the Tasks API for this field, but no general guidance on how to use it.
Version
All
Checklist
For more information on following Developer Certificate of Origin and signing off your commits, please check here.