-
Notifications
You must be signed in to change notification settings - Fork 508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tarball installation guide refactor #881
Conversation
Signed-off-by: JeffH-AWS <[email protected]>
Had to open this new PR because the old one (#855) included a commit missing DCO. Since this is a draft PR the commit history isn't important so I've just cut a new branch with a clean history. Looks like DCO is working on my new laptop now, though! |
Signed-off-by: JeffH-AWS <[email protected]>
Signed-off-by: JeffH-AWS <[email protected]>
Signed-off-by: JeffH-AWS <[email protected]>
Signed-off-by: JeffH-AWS <[email protected]>
Signed-off-by: JeffH-AWS <[email protected]>
Signed-off-by: JeffH-AWS <[email protected]>
Signed-off-by: JeffH-AWS <[email protected]>
…s guide Signed-off-by: JeffH-AWS <[email protected]>
Signed-off-by: JeffH-AWS <[email protected]>
Signed-off-by: JeffH-AWS <[email protected]>
Signed-off-by: JeffH-AWS <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Insert comma after distribution; delete commas surrounding the verbiage "but not limited to;" delete that verbiage too. For example, "...distributions, including CentOS..."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - left a couple of comments.
This guide is now pending editorial review. Please DO NOT MERGE until that review is completed. |
Signed-off-by: JeffH-AWS <[email protected]>
Signed-off-by: JeffH-AWS <[email protected]>
Per discussion with the editor last week, this should be ready to publish sometime this week. |
Signed-off-by: JeffH-AWS <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JeffH-AWS Please see my comments and let me know if you have any questions. Thanks!
Signed-off-by: JeffH-AWS <[email protected]>
Signed-off-by: JeffH-AWS <[email protected]>
* New PR because the old one was corrupted by a commit without DCO Signed-off-by: JeffH-AWS <[email protected]> * Fixed syntax for bullet/numbered lists. Signed-off-by: JeffH-AWS <[email protected]> * Added validation steps to the end Signed-off-by: JeffH-AWS <[email protected]> * Cleaning up phrasing and grammar Signed-off-by: JeffH-AWS <[email protected]> * Making some changes based on peer feedback Signed-off-by: JeffH-AWS <[email protected]> * Fixing opening section Signed-off-by: JeffH-AWS <[email protected]> * Fixing phrasing and rewording headers Signed-off-by: JeffH-AWS <[email protected]> * Cleaning up more Signed-off-by: JeffH-AWS <[email protected]> * Moved unrelated content to the appropriate pages and deleted from this guide Signed-off-by: JeffH-AWS <[email protected]> * Added templates for links Signed-off-by: JeffH-AWS <[email protected]> * Added a few related links that make sense as logical next steps Signed-off-by: JeffH-AWS <[email protected]> * Cleaned up link formatting. Ready for review now. Signed-off-by: JeffH-AWS <[email protected]> * Applied changes recommended by vagimeli Signed-off-by: JeffH-AWS <[email protected]> * Applied changed from PR review Signed-off-by: JeffH-AWS <[email protected]> * Added step numbers to headers and periods to bullet list at the top Signed-off-by: JeffH-AWS <[email protected]> * Fix typo in script comment Signed-off-by: JeffH-AWS <[email protected]> * Made most of the editorial changes but there are a couple open items Signed-off-by: JeffH-AWS <[email protected]> * Final editorial changes applied, ready to merge Signed-off-by: JeffH-AWS <[email protected]> Signed-off-by: JeffH-AWS <[email protected]> (cherry picked from commit f65dce5)
* New PR because the old one was corrupted by a commit without DCO Signed-off-by: JeffH-AWS <[email protected]> * Fixed syntax for bullet/numbered lists. Signed-off-by: JeffH-AWS <[email protected]> * Added validation steps to the end Signed-off-by: JeffH-AWS <[email protected]> * Cleaning up phrasing and grammar Signed-off-by: JeffH-AWS <[email protected]> * Making some changes based on peer feedback Signed-off-by: JeffH-AWS <[email protected]> * Fixing opening section Signed-off-by: JeffH-AWS <[email protected]> * Fixing phrasing and rewording headers Signed-off-by: JeffH-AWS <[email protected]> * Cleaning up more Signed-off-by: JeffH-AWS <[email protected]> * Moved unrelated content to the appropriate pages and deleted from this guide Signed-off-by: JeffH-AWS <[email protected]> * Added templates for links Signed-off-by: JeffH-AWS <[email protected]> * Added a few related links that make sense as logical next steps Signed-off-by: JeffH-AWS <[email protected]> * Cleaned up link formatting. Ready for review now. Signed-off-by: JeffH-AWS <[email protected]> * Applied changes recommended by vagimeli Signed-off-by: JeffH-AWS <[email protected]> * Applied changed from PR review Signed-off-by: JeffH-AWS <[email protected]> * Added step numbers to headers and periods to bullet list at the top Signed-off-by: JeffH-AWS <[email protected]> * Fix typo in script comment Signed-off-by: JeffH-AWS <[email protected]> * Made most of the editorial changes but there are a couple open items Signed-off-by: JeffH-AWS <[email protected]> * Final editorial changes applied, ready to merge Signed-off-by: JeffH-AWS <[email protected]> Signed-off-by: JeffH-AWS <[email protected]> (cherry picked from commit f65dce5)
* New PR because the old one was corrupted by a commit without DCO Signed-off-by: JeffH-AWS <[email protected]> * Fixed syntax for bullet/numbered lists. Signed-off-by: JeffH-AWS <[email protected]> * Added validation steps to the end Signed-off-by: JeffH-AWS <[email protected]> * Cleaning up phrasing and grammar Signed-off-by: JeffH-AWS <[email protected]> * Making some changes based on peer feedback Signed-off-by: JeffH-AWS <[email protected]> * Fixing opening section Signed-off-by: JeffH-AWS <[email protected]> * Fixing phrasing and rewording headers Signed-off-by: JeffH-AWS <[email protected]> * Cleaning up more Signed-off-by: JeffH-AWS <[email protected]> * Moved unrelated content to the appropriate pages and deleted from this guide Signed-off-by: JeffH-AWS <[email protected]> * Added templates for links Signed-off-by: JeffH-AWS <[email protected]> * Added a few related links that make sense as logical next steps Signed-off-by: JeffH-AWS <[email protected]> * Cleaned up link formatting. Ready for review now. Signed-off-by: JeffH-AWS <[email protected]> * Applied changes recommended by vagimeli Signed-off-by: JeffH-AWS <[email protected]> * Applied changed from PR review Signed-off-by: JeffH-AWS <[email protected]> * Added step numbers to headers and periods to bullet list at the top Signed-off-by: JeffH-AWS <[email protected]> * Fix typo in script comment Signed-off-by: JeffH-AWS <[email protected]> * Made most of the editorial changes but there are a couple open items Signed-off-by: JeffH-AWS <[email protected]> * Final editorial changes applied, ready to merge Signed-off-by: JeffH-AWS <[email protected]> Signed-off-by: JeffH-AWS <[email protected]> (cherry picked from commit f65dce5)
* New PR because the old one was corrupted by a commit without DCO Signed-off-by: JeffH-AWS <[email protected]> * Fixed syntax for bullet/numbered lists. Signed-off-by: JeffH-AWS <[email protected]> * Added validation steps to the end Signed-off-by: JeffH-AWS <[email protected]> * Cleaning up phrasing and grammar Signed-off-by: JeffH-AWS <[email protected]> * Making some changes based on peer feedback Signed-off-by: JeffH-AWS <[email protected]> * Fixing opening section Signed-off-by: JeffH-AWS <[email protected]> * Fixing phrasing and rewording headers Signed-off-by: JeffH-AWS <[email protected]> * Cleaning up more Signed-off-by: JeffH-AWS <[email protected]> * Moved unrelated content to the appropriate pages and deleted from this guide Signed-off-by: JeffH-AWS <[email protected]> * Added templates for links Signed-off-by: JeffH-AWS <[email protected]> * Added a few related links that make sense as logical next steps Signed-off-by: JeffH-AWS <[email protected]> * Cleaned up link formatting. Ready for review now. Signed-off-by: JeffH-AWS <[email protected]> * Applied changes recommended by vagimeli Signed-off-by: JeffH-AWS <[email protected]> * Applied changed from PR review Signed-off-by: JeffH-AWS <[email protected]> * Added step numbers to headers and periods to bullet list at the top Signed-off-by: JeffH-AWS <[email protected]> * Fix typo in script comment Signed-off-by: JeffH-AWS <[email protected]> * Made most of the editorial changes but there are a couple open items Signed-off-by: JeffH-AWS <[email protected]> * Final editorial changes applied, ready to merge Signed-off-by: JeffH-AWS <[email protected]> Signed-off-by: JeffH-AWS <[email protected]> (cherry picked from commit f65dce5)
* New PR because the old one was corrupted by a commit without DCO Signed-off-by: JeffH-AWS <[email protected]> * Fixed syntax for bullet/numbered lists. Signed-off-by: JeffH-AWS <[email protected]> * Added validation steps to the end Signed-off-by: JeffH-AWS <[email protected]> * Cleaning up phrasing and grammar Signed-off-by: JeffH-AWS <[email protected]> * Making some changes based on peer feedback Signed-off-by: JeffH-AWS <[email protected]> * Fixing opening section Signed-off-by: JeffH-AWS <[email protected]> * Fixing phrasing and rewording headers Signed-off-by: JeffH-AWS <[email protected]> * Cleaning up more Signed-off-by: JeffH-AWS <[email protected]> * Moved unrelated content to the appropriate pages and deleted from this guide Signed-off-by: JeffH-AWS <[email protected]> * Added templates for links Signed-off-by: JeffH-AWS <[email protected]> * Added a few related links that make sense as logical next steps Signed-off-by: JeffH-AWS <[email protected]> * Cleaned up link formatting. Ready for review now. Signed-off-by: JeffH-AWS <[email protected]> * Applied changes recommended by vagimeli Signed-off-by: JeffH-AWS <[email protected]> * Applied changed from PR review Signed-off-by: JeffH-AWS <[email protected]> * Added step numbers to headers and periods to bullet list at the top Signed-off-by: JeffH-AWS <[email protected]> * Fix typo in script comment Signed-off-by: JeffH-AWS <[email protected]> * Made most of the editorial changes but there are a couple open items Signed-off-by: JeffH-AWS <[email protected]> * Final editorial changes applied, ready to merge Signed-off-by: JeffH-AWS <[email protected]> Signed-off-by: JeffH-AWS <[email protected]> (cherry picked from commit f65dce5) Co-authored-by: Jeff Huss <[email protected]>
* New PR because the old one was corrupted by a commit without DCO Signed-off-by: JeffH-AWS <[email protected]> * Fixed syntax for bullet/numbered lists. Signed-off-by: JeffH-AWS <[email protected]> * Added validation steps to the end Signed-off-by: JeffH-AWS <[email protected]> * Cleaning up phrasing and grammar Signed-off-by: JeffH-AWS <[email protected]> * Making some changes based on peer feedback Signed-off-by: JeffH-AWS <[email protected]> * Fixing opening section Signed-off-by: JeffH-AWS <[email protected]> * Fixing phrasing and rewording headers Signed-off-by: JeffH-AWS <[email protected]> * Cleaning up more Signed-off-by: JeffH-AWS <[email protected]> * Moved unrelated content to the appropriate pages and deleted from this guide Signed-off-by: JeffH-AWS <[email protected]> * Added templates for links Signed-off-by: JeffH-AWS <[email protected]> * Added a few related links that make sense as logical next steps Signed-off-by: JeffH-AWS <[email protected]> * Cleaned up link formatting. Ready for review now. Signed-off-by: JeffH-AWS <[email protected]> * Applied changes recommended by vagimeli Signed-off-by: JeffH-AWS <[email protected]> * Applied changed from PR review Signed-off-by: JeffH-AWS <[email protected]> * Added step numbers to headers and periods to bullet list at the top Signed-off-by: JeffH-AWS <[email protected]> * Fix typo in script comment Signed-off-by: JeffH-AWS <[email protected]> * Made most of the editorial changes but there are a couple open items Signed-off-by: JeffH-AWS <[email protected]> * Final editorial changes applied, ready to merge Signed-off-by: JeffH-AWS <[email protected]> Signed-off-by: JeffH-AWS <[email protected]> (cherry picked from commit f65dce5) Co-authored-by: Jeff Huss <[email protected]>
* New PR because the old one was corrupted by a commit without DCO Signed-off-by: JeffH-AWS <[email protected]> * Fixed syntax for bullet/numbered lists. Signed-off-by: JeffH-AWS <[email protected]> * Added validation steps to the end Signed-off-by: JeffH-AWS <[email protected]> * Cleaning up phrasing and grammar Signed-off-by: JeffH-AWS <[email protected]> * Making some changes based on peer feedback Signed-off-by: JeffH-AWS <[email protected]> * Fixing opening section Signed-off-by: JeffH-AWS <[email protected]> * Fixing phrasing and rewording headers Signed-off-by: JeffH-AWS <[email protected]> * Cleaning up more Signed-off-by: JeffH-AWS <[email protected]> * Moved unrelated content to the appropriate pages and deleted from this guide Signed-off-by: JeffH-AWS <[email protected]> * Added templates for links Signed-off-by: JeffH-AWS <[email protected]> * Added a few related links that make sense as logical next steps Signed-off-by: JeffH-AWS <[email protected]> * Cleaned up link formatting. Ready for review now. Signed-off-by: JeffH-AWS <[email protected]> * Applied changes recommended by vagimeli Signed-off-by: JeffH-AWS <[email protected]> * Applied changed from PR review Signed-off-by: JeffH-AWS <[email protected]> * Added step numbers to headers and periods to bullet list at the top Signed-off-by: JeffH-AWS <[email protected]> * Fix typo in script comment Signed-off-by: JeffH-AWS <[email protected]> * Made most of the editorial changes but there are a couple open items Signed-off-by: JeffH-AWS <[email protected]> * Final editorial changes applied, ready to merge Signed-off-by: JeffH-AWS <[email protected]> Signed-off-by: JeffH-AWS <[email protected]> (cherry picked from commit f65dce5) Co-authored-by: Jeff Huss <[email protected]>
* New PR because the old one was corrupted by a commit without DCO Signed-off-by: JeffH-AWS <[email protected]> * Fixed syntax for bullet/numbered lists. Signed-off-by: JeffH-AWS <[email protected]> * Added validation steps to the end Signed-off-by: JeffH-AWS <[email protected]> * Cleaning up phrasing and grammar Signed-off-by: JeffH-AWS <[email protected]> * Making some changes based on peer feedback Signed-off-by: JeffH-AWS <[email protected]> * Fixing opening section Signed-off-by: JeffH-AWS <[email protected]> * Fixing phrasing and rewording headers Signed-off-by: JeffH-AWS <[email protected]> * Cleaning up more Signed-off-by: JeffH-AWS <[email protected]> * Moved unrelated content to the appropriate pages and deleted from this guide Signed-off-by: JeffH-AWS <[email protected]> * Added templates for links Signed-off-by: JeffH-AWS <[email protected]> * Added a few related links that make sense as logical next steps Signed-off-by: JeffH-AWS <[email protected]> * Cleaned up link formatting. Ready for review now. Signed-off-by: JeffH-AWS <[email protected]> * Applied changes recommended by vagimeli Signed-off-by: JeffH-AWS <[email protected]> * Applied changed from PR review Signed-off-by: JeffH-AWS <[email protected]> * Added step numbers to headers and periods to bullet list at the top Signed-off-by: JeffH-AWS <[email protected]> * Fix typo in script comment Signed-off-by: JeffH-AWS <[email protected]> * Made most of the editorial changes but there are a couple open items Signed-off-by: JeffH-AWS <[email protected]> * Final editorial changes applied, ready to merge Signed-off-by: JeffH-AWS <[email protected]> Signed-off-by: JeffH-AWS <[email protected]> (cherry picked from commit f65dce5) Co-authored-by: Jeff Huss <[email protected]>
Signed-off-by: JeffH-AWS [email protected]
Description
This PR represents the work being done around a refactor of the tarball instructions.
Issues Resolved
This PR relates to issue #789
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.