Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tarball installation guide refactor #881

Merged
merged 18 commits into from
Aug 30, 2022
Merged

Tarball installation guide refactor #881

merged 18 commits into from
Aug 30, 2022

Conversation

JeffHuss
Copy link

Signed-off-by: JeffH-AWS [email protected]

Description

This PR represents the work being done around a refactor of the tarball instructions.

Issues Resolved

This PR relates to issue #789

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@JeffHuss JeffHuss requested a review from a team as a code owner August 11, 2022 22:49
@JeffHuss JeffHuss marked this pull request as draft August 11, 2022 22:49
@JeffHuss JeffHuss added 2 - In progress Issue/PR: The issue or PR is in progress. backport 1.3 PR: Backport label for v1.3.x backport 2.0 PR: Backport label for v2.0.x v-All This issue is valid for all versions through 1.3 labels Aug 11, 2022
@JeffHuss JeffHuss added this to the 2022-Q3 milestone Aug 11, 2022
@JeffHuss
Copy link
Author

Had to open this new PR because the old one (#855) included a commit missing DCO. Since this is a draft PR the commit history isn't important so I've just cut a new branch with a clean history. Looks like DCO is working on my new laptop now, though!

JeffH-AWS added 2 commits August 15, 2022 09:53
JeffH-AWS added 3 commits August 16, 2022 07:32
@JeffHuss JeffHuss self-assigned this Aug 19, 2022
@JeffHuss JeffHuss added the backport 2.1 PR: Backport label for 2.1 label Aug 23, 2022
@JeffHuss JeffHuss added 4 - Doc review PR: Doc review in progress and removed 2 - In progress Issue/PR: The issue or PR is in progress. labels Aug 24, 2022
@JeffHuss JeffHuss marked this pull request as ready for review August 24, 2022 16:38
Copy link
Contributor

@vagimeli vagimeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Insert comma after distribution; delete commas surrounding the verbiage "but not limited to;" delete that verbiage too. For example, "...distributions, including CentOS..."

Copy link
Collaborator

@kolchfa-aws kolchfa-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - left a couple of comments.

@JeffHuss JeffHuss added 5 - Editorial review PR: Editorial review in progress and removed 4 - Doc review PR: Doc review in progress labels Aug 25, 2022
@JeffHuss
Copy link
Author

This guide is now pending editorial review. Please DO NOT MERGE until that review is completed.

@JeffHuss JeffHuss added the backport 2.2 PR: Backport label for 2.2 label Aug 25, 2022
@JeffHuss
Copy link
Author

Per discussion with the editor last week, this should be ready to publish sometime this week.

Signed-off-by: JeffH-AWS <[email protected]>
Copy link
Collaborator

@natebower natebower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JeffH-AWS Please see my comments and let me know if you have any questions. Thanks!

_opensearch/install/tar.md Outdated Show resolved Hide resolved
_opensearch/install/tar.md Outdated Show resolved Hide resolved
_opensearch/install/tar.md Outdated Show resolved Hide resolved
_opensearch/install/tar.md Outdated Show resolved Hide resolved
_opensearch/install/tar.md Outdated Show resolved Hide resolved
_opensearch/install/tar.md Outdated Show resolved Hide resolved
_opensearch/install/tar.md Outdated Show resolved Hide resolved
_opensearch/install/tar.md Outdated Show resolved Hide resolved
_opensearch/install/tar.md Outdated Show resolved Hide resolved
_opensearch/install/tar.md Show resolved Hide resolved
@natebower natebower removed the 5 - Editorial review PR: Editorial review in progress label Aug 29, 2022
@JeffHuss JeffHuss merged commit f65dce5 into main Aug 30, 2022
opensearch-trigger-bot bot pushed a commit that referenced this pull request Aug 30, 2022
* New PR because the old one was corrupted by a commit without DCO

Signed-off-by: JeffH-AWS <[email protected]>

* Fixed syntax for bullet/numbered lists.

Signed-off-by: JeffH-AWS <[email protected]>

* Added validation steps to the end

Signed-off-by: JeffH-AWS <[email protected]>

* Cleaning up phrasing and grammar

Signed-off-by: JeffH-AWS <[email protected]>

* Making some changes based on peer feedback

Signed-off-by: JeffH-AWS <[email protected]>

* Fixing opening section

Signed-off-by: JeffH-AWS <[email protected]>

* Fixing phrasing and rewording headers

Signed-off-by: JeffH-AWS <[email protected]>

* Cleaning up more

Signed-off-by: JeffH-AWS <[email protected]>

* Moved unrelated content to the appropriate pages and deleted from this guide

Signed-off-by: JeffH-AWS <[email protected]>

* Added templates for links

Signed-off-by: JeffH-AWS <[email protected]>

* Added a few related links that make sense as logical next steps

Signed-off-by: JeffH-AWS <[email protected]>

* Cleaned up link formatting. Ready for review now.

Signed-off-by: JeffH-AWS <[email protected]>

* Applied changes recommended by vagimeli

Signed-off-by: JeffH-AWS <[email protected]>

* Applied changed from PR review

Signed-off-by: JeffH-AWS <[email protected]>

* Added step numbers to headers and periods to bullet list at the top

Signed-off-by: JeffH-AWS <[email protected]>

* Fix typo in script comment

Signed-off-by: JeffH-AWS <[email protected]>

* Made most of the editorial changes but there are a couple open items

Signed-off-by: JeffH-AWS <[email protected]>

* Final editorial changes applied, ready to merge

Signed-off-by: JeffH-AWS <[email protected]>

Signed-off-by: JeffH-AWS <[email protected]>
(cherry picked from commit f65dce5)
opensearch-trigger-bot bot pushed a commit that referenced this pull request Aug 30, 2022
* New PR because the old one was corrupted by a commit without DCO

Signed-off-by: JeffH-AWS <[email protected]>

* Fixed syntax for bullet/numbered lists.

Signed-off-by: JeffH-AWS <[email protected]>

* Added validation steps to the end

Signed-off-by: JeffH-AWS <[email protected]>

* Cleaning up phrasing and grammar

Signed-off-by: JeffH-AWS <[email protected]>

* Making some changes based on peer feedback

Signed-off-by: JeffH-AWS <[email protected]>

* Fixing opening section

Signed-off-by: JeffH-AWS <[email protected]>

* Fixing phrasing and rewording headers

Signed-off-by: JeffH-AWS <[email protected]>

* Cleaning up more

Signed-off-by: JeffH-AWS <[email protected]>

* Moved unrelated content to the appropriate pages and deleted from this guide

Signed-off-by: JeffH-AWS <[email protected]>

* Added templates for links

Signed-off-by: JeffH-AWS <[email protected]>

* Added a few related links that make sense as logical next steps

Signed-off-by: JeffH-AWS <[email protected]>

* Cleaned up link formatting. Ready for review now.

Signed-off-by: JeffH-AWS <[email protected]>

* Applied changes recommended by vagimeli

Signed-off-by: JeffH-AWS <[email protected]>

* Applied changed from PR review

Signed-off-by: JeffH-AWS <[email protected]>

* Added step numbers to headers and periods to bullet list at the top

Signed-off-by: JeffH-AWS <[email protected]>

* Fix typo in script comment

Signed-off-by: JeffH-AWS <[email protected]>

* Made most of the editorial changes but there are a couple open items

Signed-off-by: JeffH-AWS <[email protected]>

* Final editorial changes applied, ready to merge

Signed-off-by: JeffH-AWS <[email protected]>

Signed-off-by: JeffH-AWS <[email protected]>
(cherry picked from commit f65dce5)
opensearch-trigger-bot bot pushed a commit that referenced this pull request Aug 30, 2022
* New PR because the old one was corrupted by a commit without DCO

Signed-off-by: JeffH-AWS <[email protected]>

* Fixed syntax for bullet/numbered lists.

Signed-off-by: JeffH-AWS <[email protected]>

* Added validation steps to the end

Signed-off-by: JeffH-AWS <[email protected]>

* Cleaning up phrasing and grammar

Signed-off-by: JeffH-AWS <[email protected]>

* Making some changes based on peer feedback

Signed-off-by: JeffH-AWS <[email protected]>

* Fixing opening section

Signed-off-by: JeffH-AWS <[email protected]>

* Fixing phrasing and rewording headers

Signed-off-by: JeffH-AWS <[email protected]>

* Cleaning up more

Signed-off-by: JeffH-AWS <[email protected]>

* Moved unrelated content to the appropriate pages and deleted from this guide

Signed-off-by: JeffH-AWS <[email protected]>

* Added templates for links

Signed-off-by: JeffH-AWS <[email protected]>

* Added a few related links that make sense as logical next steps

Signed-off-by: JeffH-AWS <[email protected]>

* Cleaned up link formatting. Ready for review now.

Signed-off-by: JeffH-AWS <[email protected]>

* Applied changes recommended by vagimeli

Signed-off-by: JeffH-AWS <[email protected]>

* Applied changed from PR review

Signed-off-by: JeffH-AWS <[email protected]>

* Added step numbers to headers and periods to bullet list at the top

Signed-off-by: JeffH-AWS <[email protected]>

* Fix typo in script comment

Signed-off-by: JeffH-AWS <[email protected]>

* Made most of the editorial changes but there are a couple open items

Signed-off-by: JeffH-AWS <[email protected]>

* Final editorial changes applied, ready to merge

Signed-off-by: JeffH-AWS <[email protected]>

Signed-off-by: JeffH-AWS <[email protected]>
(cherry picked from commit f65dce5)
opensearch-trigger-bot bot pushed a commit that referenced this pull request Aug 30, 2022
* New PR because the old one was corrupted by a commit without DCO

Signed-off-by: JeffH-AWS <[email protected]>

* Fixed syntax for bullet/numbered lists.

Signed-off-by: JeffH-AWS <[email protected]>

* Added validation steps to the end

Signed-off-by: JeffH-AWS <[email protected]>

* Cleaning up phrasing and grammar

Signed-off-by: JeffH-AWS <[email protected]>

* Making some changes based on peer feedback

Signed-off-by: JeffH-AWS <[email protected]>

* Fixing opening section

Signed-off-by: JeffH-AWS <[email protected]>

* Fixing phrasing and rewording headers

Signed-off-by: JeffH-AWS <[email protected]>

* Cleaning up more

Signed-off-by: JeffH-AWS <[email protected]>

* Moved unrelated content to the appropriate pages and deleted from this guide

Signed-off-by: JeffH-AWS <[email protected]>

* Added templates for links

Signed-off-by: JeffH-AWS <[email protected]>

* Added a few related links that make sense as logical next steps

Signed-off-by: JeffH-AWS <[email protected]>

* Cleaned up link formatting. Ready for review now.

Signed-off-by: JeffH-AWS <[email protected]>

* Applied changes recommended by vagimeli

Signed-off-by: JeffH-AWS <[email protected]>

* Applied changed from PR review

Signed-off-by: JeffH-AWS <[email protected]>

* Added step numbers to headers and periods to bullet list at the top

Signed-off-by: JeffH-AWS <[email protected]>

* Fix typo in script comment

Signed-off-by: JeffH-AWS <[email protected]>

* Made most of the editorial changes but there are a couple open items

Signed-off-by: JeffH-AWS <[email protected]>

* Final editorial changes applied, ready to merge

Signed-off-by: JeffH-AWS <[email protected]>

Signed-off-by: JeffH-AWS <[email protected]>
(cherry picked from commit f65dce5)
JeffHuss pushed a commit that referenced this pull request Aug 30, 2022
* New PR because the old one was corrupted by a commit without DCO

Signed-off-by: JeffH-AWS <[email protected]>

* Fixed syntax for bullet/numbered lists.

Signed-off-by: JeffH-AWS <[email protected]>

* Added validation steps to the end

Signed-off-by: JeffH-AWS <[email protected]>

* Cleaning up phrasing and grammar

Signed-off-by: JeffH-AWS <[email protected]>

* Making some changes based on peer feedback

Signed-off-by: JeffH-AWS <[email protected]>

* Fixing opening section

Signed-off-by: JeffH-AWS <[email protected]>

* Fixing phrasing and rewording headers

Signed-off-by: JeffH-AWS <[email protected]>

* Cleaning up more

Signed-off-by: JeffH-AWS <[email protected]>

* Moved unrelated content to the appropriate pages and deleted from this guide

Signed-off-by: JeffH-AWS <[email protected]>

* Added templates for links

Signed-off-by: JeffH-AWS <[email protected]>

* Added a few related links that make sense as logical next steps

Signed-off-by: JeffH-AWS <[email protected]>

* Cleaned up link formatting. Ready for review now.

Signed-off-by: JeffH-AWS <[email protected]>

* Applied changes recommended by vagimeli

Signed-off-by: JeffH-AWS <[email protected]>

* Applied changed from PR review

Signed-off-by: JeffH-AWS <[email protected]>

* Added step numbers to headers and periods to bullet list at the top

Signed-off-by: JeffH-AWS <[email protected]>

* Fix typo in script comment

Signed-off-by: JeffH-AWS <[email protected]>

* Made most of the editorial changes but there are a couple open items

Signed-off-by: JeffH-AWS <[email protected]>

* Final editorial changes applied, ready to merge

Signed-off-by: JeffH-AWS <[email protected]>

Signed-off-by: JeffH-AWS <[email protected]>
(cherry picked from commit f65dce5)

Co-authored-by: Jeff Huss <[email protected]>
JeffHuss pushed a commit that referenced this pull request Aug 30, 2022
* New PR because the old one was corrupted by a commit without DCO

Signed-off-by: JeffH-AWS <[email protected]>

* Fixed syntax for bullet/numbered lists.

Signed-off-by: JeffH-AWS <[email protected]>

* Added validation steps to the end

Signed-off-by: JeffH-AWS <[email protected]>

* Cleaning up phrasing and grammar

Signed-off-by: JeffH-AWS <[email protected]>

* Making some changes based on peer feedback

Signed-off-by: JeffH-AWS <[email protected]>

* Fixing opening section

Signed-off-by: JeffH-AWS <[email protected]>

* Fixing phrasing and rewording headers

Signed-off-by: JeffH-AWS <[email protected]>

* Cleaning up more

Signed-off-by: JeffH-AWS <[email protected]>

* Moved unrelated content to the appropriate pages and deleted from this guide

Signed-off-by: JeffH-AWS <[email protected]>

* Added templates for links

Signed-off-by: JeffH-AWS <[email protected]>

* Added a few related links that make sense as logical next steps

Signed-off-by: JeffH-AWS <[email protected]>

* Cleaned up link formatting. Ready for review now.

Signed-off-by: JeffH-AWS <[email protected]>

* Applied changes recommended by vagimeli

Signed-off-by: JeffH-AWS <[email protected]>

* Applied changed from PR review

Signed-off-by: JeffH-AWS <[email protected]>

* Added step numbers to headers and periods to bullet list at the top

Signed-off-by: JeffH-AWS <[email protected]>

* Fix typo in script comment

Signed-off-by: JeffH-AWS <[email protected]>

* Made most of the editorial changes but there are a couple open items

Signed-off-by: JeffH-AWS <[email protected]>

* Final editorial changes applied, ready to merge

Signed-off-by: JeffH-AWS <[email protected]>

Signed-off-by: JeffH-AWS <[email protected]>
(cherry picked from commit f65dce5)

Co-authored-by: Jeff Huss <[email protected]>
JeffHuss pushed a commit that referenced this pull request Aug 30, 2022
* New PR because the old one was corrupted by a commit without DCO

Signed-off-by: JeffH-AWS <[email protected]>

* Fixed syntax for bullet/numbered lists.

Signed-off-by: JeffH-AWS <[email protected]>

* Added validation steps to the end

Signed-off-by: JeffH-AWS <[email protected]>

* Cleaning up phrasing and grammar

Signed-off-by: JeffH-AWS <[email protected]>

* Making some changes based on peer feedback

Signed-off-by: JeffH-AWS <[email protected]>

* Fixing opening section

Signed-off-by: JeffH-AWS <[email protected]>

* Fixing phrasing and rewording headers

Signed-off-by: JeffH-AWS <[email protected]>

* Cleaning up more

Signed-off-by: JeffH-AWS <[email protected]>

* Moved unrelated content to the appropriate pages and deleted from this guide

Signed-off-by: JeffH-AWS <[email protected]>

* Added templates for links

Signed-off-by: JeffH-AWS <[email protected]>

* Added a few related links that make sense as logical next steps

Signed-off-by: JeffH-AWS <[email protected]>

* Cleaned up link formatting. Ready for review now.

Signed-off-by: JeffH-AWS <[email protected]>

* Applied changes recommended by vagimeli

Signed-off-by: JeffH-AWS <[email protected]>

* Applied changed from PR review

Signed-off-by: JeffH-AWS <[email protected]>

* Added step numbers to headers and periods to bullet list at the top

Signed-off-by: JeffH-AWS <[email protected]>

* Fix typo in script comment

Signed-off-by: JeffH-AWS <[email protected]>

* Made most of the editorial changes but there are a couple open items

Signed-off-by: JeffH-AWS <[email protected]>

* Final editorial changes applied, ready to merge

Signed-off-by: JeffH-AWS <[email protected]>

Signed-off-by: JeffH-AWS <[email protected]>
(cherry picked from commit f65dce5)

Co-authored-by: Jeff Huss <[email protected]>
JeffHuss pushed a commit that referenced this pull request Aug 30, 2022
* New PR because the old one was corrupted by a commit without DCO

Signed-off-by: JeffH-AWS <[email protected]>

* Fixed syntax for bullet/numbered lists.

Signed-off-by: JeffH-AWS <[email protected]>

* Added validation steps to the end

Signed-off-by: JeffH-AWS <[email protected]>

* Cleaning up phrasing and grammar

Signed-off-by: JeffH-AWS <[email protected]>

* Making some changes based on peer feedback

Signed-off-by: JeffH-AWS <[email protected]>

* Fixing opening section

Signed-off-by: JeffH-AWS <[email protected]>

* Fixing phrasing and rewording headers

Signed-off-by: JeffH-AWS <[email protected]>

* Cleaning up more

Signed-off-by: JeffH-AWS <[email protected]>

* Moved unrelated content to the appropriate pages and deleted from this guide

Signed-off-by: JeffH-AWS <[email protected]>

* Added templates for links

Signed-off-by: JeffH-AWS <[email protected]>

* Added a few related links that make sense as logical next steps

Signed-off-by: JeffH-AWS <[email protected]>

* Cleaned up link formatting. Ready for review now.

Signed-off-by: JeffH-AWS <[email protected]>

* Applied changes recommended by vagimeli

Signed-off-by: JeffH-AWS <[email protected]>

* Applied changed from PR review

Signed-off-by: JeffH-AWS <[email protected]>

* Added step numbers to headers and periods to bullet list at the top

Signed-off-by: JeffH-AWS <[email protected]>

* Fix typo in script comment

Signed-off-by: JeffH-AWS <[email protected]>

* Made most of the editorial changes but there are a couple open items

Signed-off-by: JeffH-AWS <[email protected]>

* Final editorial changes applied, ready to merge

Signed-off-by: JeffH-AWS <[email protected]>

Signed-off-by: JeffH-AWS <[email protected]>
(cherry picked from commit f65dce5)

Co-authored-by: Jeff Huss <[email protected]>
@Naarcha-AWS Naarcha-AWS deleted the tar-install-steps branch September 14, 2022 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 1.3 PR: Backport label for v1.3.x backport 2.0 PR: Backport label for v2.0.x backport 2.1 PR: Backport label for 2.1 backport 2.2 PR: Backport label for 2.2 v-All This issue is valid for all versions through 1.3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants