Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update logging-features.md #8795

Merged
merged 2 commits into from
Nov 21, 2024
Merged

Conversation

sstults
Copy link
Contributor

@sstults sstults commented Nov 21, 2024

Add a link to hello-ltr demo for context about the index schema

Description

Add a link to the ltr-demo site near the top of the example query to give context about the schema it references.

Issues Resolved

Closes #8794

Version

2.17.1 -

Frontend features

If you're submitting documentation for an OpenSearch Dashboards feature, add a video that shows how a user will interact with the UI step by step. A voiceover is optional.

Checklist

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Add a link to hello-ltr demo for context about the index schema

Signed-off-by: Scott Stults <[email protected]>
Copy link

Thank you for submitting your PR. The PR states are In progress (or Draft) -> Tech review -> Doc review -> Editorial review -> Merged.

Before you submit your PR for doc review, make sure the content is technically accurate. If you need help finding a tech reviewer, tag a maintainer.

When you're ready for doc review, tag the assignee of this PR. The doc reviewer may push edits to the PR directly or leave comments and editorial suggestions for you to address (let us know in a comment if you have a preference). The doc reviewer will arrange for an editorial review.

Copy link
Collaborator

@kolchfa-aws kolchfa-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @sstults! One suggestion.

_search-plugins/ltr/logging-features.md Outdated Show resolved Hide resolved
Co-authored-by: kolchfa-aws <[email protected]>
Signed-off-by: Scott Stults <[email protected]>
@kolchfa-aws kolchfa-aws added the backport 2.18 PR: Backport label for 2.18 label Nov 21, 2024
@kolchfa-aws kolchfa-aws merged commit b50a3eb into opensearch-project:main Nov 21, 2024
7 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Nov 21, 2024
* Update logging-features.md

Add a link to hello-ltr demo for context about the index schema

Signed-off-by: Scott Stults <[email protected]>

* Update _search-plugins/ltr/logging-features.md

Co-authored-by: kolchfa-aws <[email protected]>
Signed-off-by: Scott Stults <[email protected]>

---------

Signed-off-by: Scott Stults <[email protected]>
Co-authored-by: kolchfa-aws <[email protected]>
(cherry picked from commit b50a3eb)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
github-actions bot pushed a commit that referenced this pull request Nov 21, 2024
epugh pushed a commit to o19s/documentation-website that referenced this pull request Nov 23, 2024
* Update logging-features.md

Add a link to hello-ltr demo for context about the index schema

Signed-off-by: Scott Stults <[email protected]>

* Update _search-plugins/ltr/logging-features.md

Co-authored-by: kolchfa-aws <[email protected]>
Signed-off-by: Scott Stults <[email protected]>

---------

Signed-off-by: Scott Stults <[email protected]>
Co-authored-by: kolchfa-aws <[email protected]>
Signed-off-by: Eric Pugh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.18 PR: Backport label for 2.18
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DOC] Add a link to the LTR demo site to clarify the example
2 participants