Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additions to data source acceleration #8759

Merged
merged 10 commits into from
Nov 19, 2024

Conversation

lizsnyder
Copy link
Member

Description

I'm updating this topic to include some functionality that must have been added by the dev team. I'm also porting over some SQL query examples from the service docs: https://docs.aws.amazon.com/opensearch-service/latest/developerguide/direct-query-s3-configure-accelerate.html

They belong in the open source docs, and we plan to remove them from the AWS docs.

Issues Resolved

N/A

Version

All

Frontend features

N/A

Checklist

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

Thank you for submitting your PR. The PR states are In progress (or Draft) -> Tech review -> Doc review -> Editorial review -> Merged.

Before you submit your PR for doc review, make sure the content is technically accurate. If you need help finding a tech reviewer, tag a maintainer.

When you're ready for doc review, tag the assignee of this PR. The doc reviewer may push edits to the PR directly or leave comments and editorial suggestions for you to address (let us know in a comment if you have a preference). The doc reviewer will arrange for an editorial review.

@kolchfa-aws kolchfa-aws assigned vagimeli and unassigned kolchfa-aws Nov 15, 2024
@lizsnyder
Copy link
Member Author

@vagimeli you can also reach out to @Naarcha-AWS if you have questions, he has context on this.

@kolchfa-aws kolchfa-aws assigned Naarcha-AWS and unassigned vagimeli Nov 15, 2024
@kolchfa-aws
Copy link
Collaborator

Assigning @Naarcha-AWS because he's familiar with this change.

Copy link
Collaborator

@Naarcha-AWS Naarcha-AWS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small changes, otherwise LGTM.

_dashboards/management/accelerate-external-data.md Outdated Show resolved Hide resolved
_dashboards/management/accelerate-external-data.md Outdated Show resolved Hide resolved
_dashboards/management/accelerate-external-data.md Outdated Show resolved Hide resolved
_dashboards/management/accelerate-external-data.md Outdated Show resolved Hide resolved
_dashboards/management/accelerate-external-data.md Outdated Show resolved Hide resolved
_dashboards/management/accelerate-external-data.md Outdated Show resolved Hide resolved
@lizsnyder
Copy link
Member Author

Implemented all of @Naarcha-AWS's comments.

@Naarcha-AWS Naarcha-AWS added backport 2.18 PR: Backport label for 2.18 backport 2.17 Backport for version 2.17 backport 2.16 labels Nov 19, 2024
@Naarcha-AWS Naarcha-AWS merged commit 03c8b18 into opensearch-project:main Nov 19, 2024
9 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.15 failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.15 2.15
# Navigate to the new working tree
pushd ../.worktrees/backport-2.15
# Create a new branch
git switch --create backport/backport-8759-to-2.15
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 03c8b18678250befa073744fd9ce5af52be09c63
# Push it to GitHub
git push --set-upstream origin backport/backport-8759-to-2.15
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.15

Then, create a pull request where the base branch is 2.15 and the compare/head branch is backport/backport-8759-to-2.15.

@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.16 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.16 2.16
# Navigate to the new working tree
pushd ../.worktrees/backport-2.16
# Create a new branch
git switch --create backport/backport-8759-to-2.16
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 03c8b18678250befa073744fd9ce5af52be09c63
# Push it to GitHub
git push --set-upstream origin backport/backport-8759-to-2.16
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.16

Then, create a pull request where the base branch is 2.16 and the compare/head branch is backport/backport-8759-to-2.16.

@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.17 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.17 2.17
# Navigate to the new working tree
pushd ../.worktrees/backport-2.17
# Create a new branch
git switch --create backport/backport-8759-to-2.17
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 03c8b18678250befa073744fd9ce5af52be09c63
# Push it to GitHub
git push --set-upstream origin backport/backport-8759-to-2.17
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.17

Then, create a pull request where the base branch is 2.17 and the compare/head branch is backport/backport-8759-to-2.17.

@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.18 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.18 2.18
# Navigate to the new working tree
pushd ../.worktrees/backport-2.18
# Create a new branch
git switch --create backport/backport-8759-to-2.18
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 03c8b18678250befa073744fd9ce5af52be09c63
# Push it to GitHub
git push --set-upstream origin backport/backport-8759-to-2.18
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.18

Then, create a pull request where the base branch is 2.18 and the compare/head branch is backport/backport-8759-to-2.18.

epugh pushed a commit to o19s/documentation-website that referenced this pull request Nov 23, 2024
* Additions to data source acceleration

Signed-off-by: Liz Snyder <[email protected]>

* Update _dashboards/management/accelerate-external-data.md

Co-authored-by: Naarcha-AWS <[email protected]>
Signed-off-by: Liz Snyder <[email protected]>

* Update _dashboards/management/accelerate-external-data.md

Co-authored-by: Naarcha-AWS <[email protected]>
Signed-off-by: Liz Snyder <[email protected]>

* Update _dashboards/management/accelerate-external-data.md

Co-authored-by: Naarcha-AWS <[email protected]>
Signed-off-by: Liz Snyder <[email protected]>

* Implement feedback

Signed-off-by: Liz Snyder <[email protected]>

* Update required ruby version

Signed-off-by: Liz Snyder <[email protected]>

---------

Signed-off-by: Liz Snyder <[email protected]>
Co-authored-by: kolchfa-aws <[email protected]>
Co-authored-by: Naarcha-AWS <[email protected]>
Signed-off-by: Eric Pugh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.15 backport 2.16 backport 2.17 Backport for version 2.17 backport 2.18 PR: Backport label for 2.18
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants