Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nested.md #8700

Merged
merged 3 commits into from
Nov 11, 2024
Merged

Update nested.md #8700

merged 3 commits into from
Nov 11, 2024

Conversation

meve
Copy link
Contributor

@meve meve commented Nov 8, 2024

Fix a small error in example response

Description

Nothing, just a small copy/paste mistake in the docs. In fact, when I ran the example, it returned:

  "aggregations": {
    "pages": {
      "doc_count": 2,
      "min_load_time": {
        "value": 200
      }
    }
  }

So technically also without the .0.

Issues Resolved

Not applicable.

Version

Not applicable.

Frontend features

Not applicable.

Checklist

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Fix a small error in example response

Signed-off-by: Joost Veen <[email protected]>
Copy link

github-actions bot commented Nov 8, 2024

Thank you for submitting your PR. The PR states are In progress (or Draft) -> Tech review -> Doc review -> Editorial review -> Merged.

Before you submit your PR for doc review, make sure the content is technically accurate. If you need help finding a tech reviewer, tag a maintainer.

When you're ready for doc review, tag the assignee of this PR. The doc reviewer may push edits to the PR directly or leave comments and editorial suggestions for you to address (let us know in a comment if you have a preference). The doc reviewer will arrange for an editorial review.

Copy link
Collaborator

@kolchfa-aws kolchfa-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you, @meve!

@kolchfa-aws kolchfa-aws merged commit 5d2e3d6 into opensearch-project:main Nov 11, 2024
5 checks passed
@kolchfa-aws kolchfa-aws added the backport 2.18 PR: Backport label for 2.18 label Nov 11, 2024
opensearch-trigger-bot bot pushed a commit that referenced this pull request Nov 11, 2024
* Update nested.md

Fix a small error in example response

Signed-off-by: Joost Veen <[email protected]>

* Apply suggestions from code review

Signed-off-by: kolchfa-aws <[email protected]>

---------

Signed-off-by: Joost Veen <[email protected]>
Signed-off-by: kolchfa-aws <[email protected]>
Co-authored-by: kolchfa-aws <[email protected]>
(cherry picked from commit 5d2e3d6)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
github-actions bot pushed a commit that referenced this pull request Nov 11, 2024
epugh pushed a commit to o19s/documentation-website that referenced this pull request Nov 23, 2024
* Update nested.md

Fix a small error in example response

Signed-off-by: Joost Veen <[email protected]>

* Apply suggestions from code review

Signed-off-by: kolchfa-aws <[email protected]>

---------

Signed-off-by: Joost Veen <[email protected]>
Signed-off-by: kolchfa-aws <[email protected]>
Co-authored-by: kolchfa-aws <[email protected]>
Signed-off-by: Eric Pugh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.18 PR: Backport label for 2.18
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants