Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added tutorial on ML Inference processor with the by-field rerank type #8694

Merged
merged 24 commits into from
Nov 25, 2024

Conversation

brianf-aws
Copy link
Contributor

Description

We needed to show users the power of combining a agnostic remote model inference processor and reranking your documents based on what was returned by the ml inference processor. Testing was done by running a docker compose using the commands shown in the tutorial.

Issues Resolved

Closes opensearch-project/ml-commons#3175
Closes #8693

Version

2.18

Checklist

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

We needed to show users the power of combining a agnostic remote model inference processor and reranking your documents based on what was returned by the ml inference processor. Testing was done by running a docker compose using the commands shown in the tutorial.

Signed-off-by: Brian Flores <[email protected]>
Copy link

github-actions bot commented Nov 7, 2024

Thank you for submitting your PR. The PR states are In progress (or Draft) -> Tech review -> Doc review -> Editorial review -> Merged.

Before you submit your PR for doc review, make sure the content is technically accurate. If you need help finding a tech reviewer, tag a maintainer.

When you're ready for doc review, tag the assignee of this PR. The doc reviewer may push edits to the PR directly or leave comments and editorial suggestions for you to address (let us know in a comment if you have a preference). The doc reviewer will arrange for an editorial review.

@brianf-aws
Copy link
Contributor Author

Hey @kolchfa-aws! I think this PR is ready to be reviewed. Do you mind taking a look? Thank you

Signed-off-by: Fanit Kolchina <[email protected]>
Signed-off-by: Fanit Kolchina <[email protected]>
Signed-off-by: Fanit Kolchina <[email protected]>
Signed-off-by: Fanit Kolchina <[email protected]>
Copy link
Contributor Author

@brianf-aws brianf-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some high level edits overall I like the review

Copy link
Collaborator

@natebower natebower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kolchfa-aws @brianf-aws Please see my comment and changes and let me know if you have any questions. Thanks!

@@ -0,0 +1,276 @@
---
layout: default
title: Reranking by a field using a cross-encoder
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"using an externally hosted cross-encoder model"?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is too long for a left nav; that's why I shortened it

Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: kolchfa-aws <[email protected]>
@kolchfa-aws kolchfa-aws added the backport 2.18 PR: Backport label for 2.18 label Nov 25, 2024
@kolchfa-aws kolchfa-aws merged commit db21c43 into opensearch-project:main Nov 25, 2024
5 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Nov 25, 2024
#8694)

* Added tutorial on ML Inference processor with the by-field rerank type

We needed to show users the power of combining a agnostic remote model inference processor and reranking your documents based on what was returned by the ml inference processor. Testing was done by running a docker compose using the commands shown in the tutorial.

Signed-off-by: Brian Flores <[email protected]>

* Update _search-plugins/search-relevance/ml-inference-rerank-by-field.md

removed unneeded comment

Signed-off-by: Brian Flores <[email protected]>

* Update _search-plugins/search-relevance/ml-inference-rerank-by-field.md

Capitalized Harlem

Signed-off-by: Brian Flores <[email protected]>

* Added SageMaker step and links to processors

Signed-off-by: Brian Flores <[email protected]>

* fix: grammar and simplifying tutorial

Signed-off-by: Brian Flores <[email protected]>

* Fix: broken link

Signed-off-by: Brian Flores <[email protected]>

* Update _search-plugins/search-relevance/ml-inference-rerank-by-field.md

Signed-off-by: Brian Flores <[email protected]>

* Doc review

Signed-off-by: Fanit Kolchina <[email protected]>

* Add copy button

Signed-off-by: Fanit Kolchina <[email protected]>

* Small rewrite

Signed-off-by: Fanit Kolchina <[email protected]>

* Heading change

Signed-off-by: Fanit Kolchina <[email protected]>

* updating explanation on pipeline config

Signed-off-by: Brian Flores <[email protected]>

* spacing on config

Signed-off-by: Brian Flores <[email protected]>

* Added endpoint info

Signed-off-by: Brian Flores <[email protected]>

* modelUrl -> Sagemaker_endpoint

Signed-off-by: Brian Flores <[email protected]>

* Rewording

Signed-off-by: Fanit Kolchina <[email protected]>

* Apply suggestions from code review

Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: kolchfa-aws <[email protected]>

---------

Signed-off-by: Brian Flores <[email protected]>
Signed-off-by: Fanit Kolchina <[email protected]>
Signed-off-by: kolchfa-aws <[email protected]>
Co-authored-by: kolchfa-aws <[email protected]>
Co-authored-by: Fanit Kolchina <[email protected]>
Co-authored-by: Nathan Bower <[email protected]>
(cherry picked from commit db21c43)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@brianf-aws
Copy link
Contributor Author

Thank you @kolchfa-aws and @natebower!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.18 PR: Backport label for 2.18
Projects
None yet
5 participants