[Jekyll] Spec Insert Plugin #8692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for submitting your PR. The PR states are In progress (or Draft) -> Tech review -> Doc review -> Editorial review -> Merged. Before you submit your PR for doc review, make sure the content is technically accurate. If you need help finding a tech reviewer, tag a maintainer. When you're ready for doc review, tag the assignee of this PR. The doc reviewer may push edits to the PR directly or leave comments and editorial suggestions for you to address (let us know in a comment if you have a preference). The doc reviewer will arrange for an editorial review. |
A program that insert API Components generated from the OpenSearch OpenAPI Spec into markdown files Signed-off-by: Theo Truong <[email protected]>
nhtruong
force-pushed
the
spec_insert_phase_1
branch
from
5741da0 to
869d2ae
Compare
Signed-off-by: Theo Truong <[email protected]>
Signed-off-by: Theo Truong <[email protected]>
nhtruong
requested review from
kolchfa-aws,
Naarcha-AWS,
vagimeli,
AMoo-Miki,
natebower,
dlvenable and
epugh
as code owners
Signed-off-by: Theo Truong <[email protected]>
Signed-off-by: Theo Truong <[email protected]>
Signed-off-by: Theo Truong <[email protected]>
|
@dblock Would you mind taking a look? Thanks |
dblock
approved these changes
Nov 8, 2024
🚢
Naarcha-AWS
reviewed
Nov 8, 2024
Co-authored-by: Naarcha-AWS <[email protected]> Co-authored-by: Daniel (dB.) Doubrovkine <[email protected]> Signed-off-by: Theo N. Truong <[email protected]>
Signed-off-by: Theo Truong <[email protected]>
|
Naarcha-AWS
reviewed
Nov 8, 2024
Signed-off-by: Naarcha-AWS <[email protected]>
Naarcha-AWS
reviewed
Nov 8, 2024
Naarcha-AWS
reviewed
Nov 8, 2024
Naarcha-AWS
reviewed
Nov 8, 2024
Signed-off-by: Naarcha-AWS <[email protected]>
Naarcha-AWS
approved these changes
Nov 8, 2024
natebower
reviewed
Nov 11, 2024
There was a problem hiding this comment.
@Naarcha-AWS @nhtruong Please see my comments and changes and let me know if you have any questions. Thanks!
natebower
reviewed
Nov 11, 2024
| @@ -0,0 +1,135 @@ | |||
| # Developer guide | |||
| - [Introduction](#introduction) | |||
| - [Starting the Jekyll server locally](#starting-the-jekyll-server-locally) | |||
There was a problem hiding this comment.
Also please correct links where necessary.
Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Naarcha-AWS <[email protected]>
epugh
pushed a commit
to o19s/documentation-website
that referenced
this pull request
Nov 23, 2024
* Spec Insert A program that insert API Components generated from the OpenSearch OpenAPI Spec into markdown files Signed-off-by: Theo Truong <[email protected]> * # Sentence casing Signed-off-by: Theo Truong <[email protected]> * # vale:reviewdog Signed-off-by: Theo Truong <[email protected]> * # vale:reviewdog Signed-off-by: Theo Truong <[email protected]> * # vale:reviewdog Signed-off-by: Theo Truong <[email protected]> * # Correction on cron job run time. Signed-off-by: Theo Truong <[email protected]> * Apply suggestions from code review Co-authored-by: Naarcha-AWS <[email protected]> Co-authored-by: Daniel (dB.) Doubrovkine <[email protected]> Signed-off-by: Theo N. Truong <[email protected]> * # More clarity in method documentation Signed-off-by: Theo Truong <[email protected]> * Update DEVELOPER_GUIDE.md * Apply suggestions from code review Signed-off-by: Naarcha-AWS <[email protected]> * Apply suggestions from code review Signed-off-by: Naarcha-AWS <[email protected]> * Apply suggestions from code review Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Naarcha-AWS <[email protected]> --------- Signed-off-by: Theo Truong <[email protected]> Signed-off-by: Theo N. Truong <[email protected]> Signed-off-by: Naarcha-AWS <[email protected]> Co-authored-by: Naarcha-AWS <[email protected]> Co-authored-by: Daniel (dB.) Doubrovkine <[email protected]> Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Eric Pugh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A program that insert API Components generated from the OpenSearch OpenAPI Spec into markdown files
Checklist
For more information on following Developer Certificate of Origin and signing off your commits, please check here.