Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document change to size > 0 setting for request cache #8684

Merged

Conversation

peteralfonsi
Copy link
Contributor

@peteralfonsi peteralfonsi commented Nov 5, 2024

Description

Minor change: The setting allowing caching size > 0 queries, from opensearch-project/OpenSearch#16484, will be tweaked in opensearch-project/OpenSearch#16570. This PR changes its documentation.

Because the original setting never entered any release other than the 2.x branch I think it's fine to change its name, but correct me if I'm wrong.

Issues Resolved

N/A

Version

2.x (new change in open source)

Frontend features

N/A

Checklist

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

github-actions bot commented Nov 5, 2024

Thank you for submitting your PR. The PR states are In progress (or Draft) -> Tech review -> Doc review -> Editorial review -> Merged.

Before you submit your PR for doc review, make sure the content is technically accurate. If you need help finding a tech reviewer, tag a maintainer.

When you're ready for doc review, tag the assignee of this PR. The doc reviewer may push edits to the PR directly or leave comments and editorial suggestions for you to address (let us know in a comment if you have a preference). The doc reviewer will arrange for an editorial review.

@peteralfonsi
Copy link
Contributor Author

Btw, the relevant PR is not merged yet. Will comment here when it is.

Copy link
Collaborator

@kolchfa-aws kolchfa-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @peteralfonsi! One suggestion.

_search-plugins/caching/request-cache.md Outdated Show resolved Hide resolved
@kolchfa-aws kolchfa-aws added the backport 2.18 PR: Backport label for 2.18 label Nov 6, 2024
Co-authored-by: kolchfa-aws <[email protected]>
Signed-off-by: Peter Alfonsi <[email protected]>
@peteralfonsi
Copy link
Contributor Author

Also, @kolchfa-aws I saw the backport 2.18 label is added - the original setting isn't in 2.18, just 2.x, so I think the backport shouldn't be needed.

@kolchfa-aws
Copy link
Collaborator

@peteralfonsi What do you mean by 2.x? Which versions of OpenSearch is this applicable to?

Copy link
Collaborator

@natebower natebower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kolchfa-aws One minor change. Thanks!

_search-plugins/caching/request-cache.md Outdated Show resolved Hide resolved
@kolchfa-aws kolchfa-aws added 6 - Done but waiting to merge PR: The work is done and ready to merge v2.19.0 release-notes PR: Include this PR in the automated release notes and removed backport 2.18 PR: Backport label for 2.18 labels Nov 13, 2024
@kolchfa-aws kolchfa-aws merged commit 47e881b into opensearch-project:main Nov 19, 2024
5 checks passed
epugh pushed a commit to o19s/documentation-website that referenced this pull request Nov 23, 2024
…ject#8684)

* document change to size > 0 setting

Signed-off-by: Peter Alfonsi <[email protected]>

* Update _search-plugins/caching/request-cache.md

Co-authored-by: kolchfa-aws <[email protected]>
Signed-off-by: Peter Alfonsi <[email protected]>

* Update _search-plugins/caching/request-cache.md

Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: kolchfa-aws <[email protected]>

---------

Signed-off-by: Peter Alfonsi <[email protected]>
Signed-off-by: Peter Alfonsi <[email protected]>
Signed-off-by: kolchfa-aws <[email protected]>
Co-authored-by: Peter Alfonsi <[email protected]>
Co-authored-by: kolchfa-aws <[email protected]>
Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Eric Pugh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6 - Done but waiting to merge PR: The work is done and ready to merge release-notes PR: Include this PR in the automated release notes v2.19.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants