-
Notifications
You must be signed in to change notification settings - Fork 503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document change to size > 0 setting for request cache #8684
Document change to size > 0 setting for request cache #8684
Conversation
Signed-off-by: Peter Alfonsi <[email protected]>
Thank you for submitting your PR. The PR states are In progress (or Draft) -> Tech review -> Doc review -> Editorial review -> Merged. Before you submit your PR for doc review, make sure the content is technically accurate. If you need help finding a tech reviewer, tag a maintainer. When you're ready for doc review, tag the assignee of this PR. The doc reviewer may push edits to the PR directly or leave comments and editorial suggestions for you to address (let us know in a comment if you have a preference). The doc reviewer will arrange for an editorial review. |
Btw, the relevant PR is not merged yet. Will comment here when it is. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @peteralfonsi! One suggestion.
Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: Peter Alfonsi <[email protected]>
Also, @kolchfa-aws I saw the backport 2.18 label is added - the original setting isn't in 2.18, just 2.x, so I think the backport shouldn't be needed. |
@peteralfonsi What do you mean by 2.x? Which versions of OpenSearch is this applicable to? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kolchfa-aws One minor change. Thanks!
Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: kolchfa-aws <[email protected]>
Signed-off-by: kolchfa-aws <[email protected]>
…ject#8684) * document change to size > 0 setting Signed-off-by: Peter Alfonsi <[email protected]> * Update _search-plugins/caching/request-cache.md Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: Peter Alfonsi <[email protected]> * Update _search-plugins/caching/request-cache.md Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: kolchfa-aws <[email protected]> --------- Signed-off-by: Peter Alfonsi <[email protected]> Signed-off-by: Peter Alfonsi <[email protected]> Signed-off-by: kolchfa-aws <[email protected]> Co-authored-by: Peter Alfonsi <[email protected]> Co-authored-by: kolchfa-aws <[email protected]> Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Eric Pugh <[email protected]>
Description
Minor change: The setting allowing caching size > 0 queries, from opensearch-project/OpenSearch#16484, will be tweaked in opensearch-project/OpenSearch#16570. This PR changes its documentation.
Because the original setting never entered any release other than the 2.x branch I think it's fine to change its name, but correct me if I'm wrong.
Issues Resolved
N/A
Version
2.x (new change in open source)
Frontend features
N/A
Checklist
For more information on following Developer Certificate of Origin and signing off your commits, please check here.