[DOC] Installing ruby for Apple silicon missing #8618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…arch-project#8614 Signed-off-by: Brian Flores <[email protected]>
Signed-off-by: Brian Flores <[email protected]>
brianf-aws
requested review from
kolchfa-aws,
Naarcha-AWS,
vagimeli,
AMoo-Miki,
natebower,
dlvenable and
epugh
as code owners
|
Thank you for submitting your PR. The PR states are In progress (or Draft) -> Tech review -> Doc review -> Editorial review -> Merged. Before you submit your PR for doc review, make sure the content is technically accurate. If you need help finding a tech reviewer, tag a maintainer. When you're ready for doc review, tag the assignee of this PR. The doc reviewer may push edits to the PR directly or leave comments and editorial suggestions for you to address (let us know in a comment if you have a preference). The doc reviewer will arrange for an editorial review. |
4 tasks
Naarcha-AWS
requested changes
Oct 24, 2024
Change header to bold for non-apple silicon. Co-authored-by: Naarcha-AWS <[email protected]> Signed-off-by: Brian Flores <[email protected]>
change header for bold for apple silicon Co-authored-by: Naarcha-AWS <[email protected]> Signed-off-by: Brian Flores <[email protected]>
This commit adds more information of where a user can look to see what openSSL versions they can use to install. this way we wont need to update both the SSL version and ruby version if it changes. Signed-off-by: Brian Flores <[email protected]>
Signed-off-by: Brian Flores <[email protected]>
Signed-off-by: Brian Flores <[email protected]>
Signed-off-by: Brian Flores <[email protected]>
Signed-off-by: Naarcha-AWS <[email protected]>
Naarcha-AWS
approved these changes
Nov 7, 2024
natebower
reviewed
Nov 8, 2024
Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Naarcha-AWS <[email protected]>
epugh
pushed a commit
to o19s/documentation-website
that referenced
this pull request
Nov 23, 2024
) * Adds documentation for installing ruby for apple silicon fixes opensearch-project#8614 Signed-off-by: Brian Flores <[email protected]> * shrinked header size Signed-off-by: Brian Flores <[email protected]> * Update CONTRIBUTING.md Change header to bold for non-apple silicon. Co-authored-by: Naarcha-AWS <[email protected]> Signed-off-by: Brian Flores <[email protected]> * Update CONTRIBUTING.md change header for bold for apple silicon Co-authored-by: Naarcha-AWS <[email protected]> Signed-off-by: Brian Flores <[email protected]> * Added place holder for openSSL version for users choice This commit adds more information of where a user can look to see what openSSL versions they can use to install. this way we wont need to update both the SSL version and ruby version if it changes. Signed-off-by: Brian Flores <[email protected]> * ruby -> Ruby Signed-off-by: Brian Flores <[email protected]> * Update CONTRIBUTING.md Signed-off-by: Brian Flores <[email protected]> * Fixed typo Signed-off-by: Brian Flores <[email protected]> * Move silicon command to new troubleshooting section. Signed-off-by: Naarcha-AWS <[email protected]> * Apply suggestions from code review Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Naarcha-AWS <[email protected]> --------- Signed-off-by: Brian Flores <[email protected]> Signed-off-by: Naarcha-AWS <[email protected]> Co-authored-by: Naarcha-AWS <[email protected]> Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Eric Pugh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add small lines for installing apple silicon, This blog post helped but I want to write it formally here to avoid any friction for future developers. I propose to change the installation step for ruby
documentation-website/CONTRIBUTING.md
Lines 84 to 89 in fb8d9d3
to
For Non-Apple Silicon machines:
For Apple Silicon machines. Source: Installing Ruby on Apple Silicon by Emmanuel Bernard
Currently the documentation for getting started as shown in the contributing doc does not show a option for instaling ruby on Apple silicon machines
*Version: all.
What other resources are available? Provide links to related issues, POCs, steps for testing, etc.