Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update JDK version for 1.3 distributions #8611

Merged
merged 2 commits into from
Dec 11, 2024

Conversation

reta
Copy link
Contributor

@reta reta commented Oct 23, 2024

Description

Update JDK version for 1.3 distributions

Issues Resolved

Coming from opensearch-project/OpenSearch#16452

Version

List the OpenSearch version to which this PR applies, e.g. 2.14, 2.12--2.14, or all.

Frontend features

If you're submitting documentation for an OpenSearch Dashboards feature, add a video that shows how a user will interact with the UI step by step. A voiceover is optional.

Checklist

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

Thank you for submitting your PR. The PR states are In progress (or Draft) -> Tech review -> Doc review -> Editorial review -> Merged.

Before you submit your PR for doc review, make sure the content is technically accurate. If you need help finding a tech reviewer, tag a maintainer.

When you're ready for doc review, tag the assignee of this PR. The doc reviewer may push edits to the PR directly or leave comments and editorial suggestions for you to address (let us know in a comment if you have a preference). The doc reviewer will arrange for an editorial review.

@reta
Copy link
Contributor Author

reta commented Oct 23, 2024

@kolchfa-aws this ideally should be merged when 1.3.20 is out, thank you!

@reta
Copy link
Contributor Author

reta commented Dec 10, 2024

@kolchfa-aws I think 1.3.20 is out, right?

@kolchfa-aws
Copy link
Collaborator

@reta Thank you for checking. It'll be out in about 3 hours, so I'll merge the PR then.

@kolchfa-aws kolchfa-aws added the backport 1.3 PR: Backport label for v1.3.x label Dec 10, 2024
@kolchfa-aws
Copy link
Collaborator

The release is moved to tomorrow so I'll merge then.

@kolchfa-aws kolchfa-aws merged commit 23729b7 into opensearch-project:main Dec 11, 2024
7 checks passed
@opensearch-trigger-bot
Copy link

The backport to 1.3 failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-1.3 1.3
# Navigate to the new working tree
pushd ../.worktrees/backport-1.3
# Create a new branch
git switch --create backport/backport-8611-to-1.3
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 23729b7dd12c819b643fe62b02fce5f1fed40520
# Push it to GitHub
git push --set-upstream origin backport/backport-8611-to-1.3
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-1.3

Then, create a pull request where the base branch is 1.3 and the compare/head branch is backport/backport-8611-to-1.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 1.3 PR: Backport label for v1.3.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants